From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>,
"Andrei E. Warkentin" <andrey.warkentin@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation
Date: Thu, 3 Apr 2014 17:53:54 +0100 [thread overview]
Message-ID: <CAFEAcA88n1gRtRd83TExxpZXOa-16wwKc-QzPK2ecLrh=48cFA@mail.gmail.com> (raw)
In-Reply-To: <533D91A3.6020802@twiddle.net>
On 3 April 2014 17:51, Richard Henderson <rth@twiddle.net> wrote:
> On 04/03/2014 09:45 AM, Peter Maydell wrote:
>> + if (have_tb_lock) {
>> + spin_unlock(&tcg_ctx.tb_ctx.tb_lock);
>> + }
>
> It ought not matter, since we ought to exit the loop on the
> next round, but i have a strong preference for resetting
> have_tb_lock here.
Absolutely -- dumb oversight on my part.
thanks
-- PMM
next prev parent reply other threads:[~2014-04-03 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:45 [Qemu-devel] [PATCH for-2.0? 0/2] fix bugs involving linux-user signal handling Peter Maydell
2014-04-03 16:45 ` [Qemu-devel] [PATCH for-2.0? 1/2] page_check_range: don't bail out early after unprotecting page Peter Maydell
2014-04-03 18:26 ` Richard Henderson
2014-04-03 16:45 ` [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation Peter Maydell
2014-04-03 16:51 ` Richard Henderson
2014-04-03 16:53 ` Peter Maydell [this message]
2014-04-03 19:38 ` Andrei E. Warkentin
2014-04-03 23:24 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA88n1gRtRd83TExxpZXOa-16wwKc-QzPK2ecLrh=48cFA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=andrey.warkentin@gmail.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).