From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7rXQ-0006go-R4 for qemu-devel@nongnu.org; Mon, 27 Jan 2014 14:08:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7rXK-0001de-TA for qemu-devel@nongnu.org; Mon, 27 Jan 2014 14:08:04 -0500 Received: from mail-la0-f52.google.com ([209.85.215.52]:34371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7rXK-0001dT-MQ for qemu-devel@nongnu.org; Mon, 27 Jan 2014 14:07:58 -0500 Received: by mail-la0-f52.google.com with SMTP id c6so4692048lan.25 for ; Mon, 27 Jan 2014 11:07:57 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1390846330-25745-1-git-send-email-pbonzini@redhat.com> References: <1390846330-25745-1-git-send-email-pbonzini@redhat.com> From: Peter Maydell Date: Mon, 27 Jan 2014 19:07:37 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH target-arm v3] display: avoid multi-statement macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: QEMU Developers On 27 January 2014 18:12, Paolo Bonzini wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while (0)", or just remove the > semicolon if there's a single statement in the macro. > > Signed-off-by: Paolo Bonzini Thanks, applied to target-arm.next. -- PMM