From: Peter Maydell <peter.maydell@linaro.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Shashi Mallela <shashi.mallela@linaro.org>,
Leif Lindholm <leif@nuviainc.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Radoslaw Biernacki <rad@semihalf.com>
Subject: Re: [PATCH for-6.2] sbsa-ref: Rename SBSA_GWDT enum value
Date: Thu, 19 Aug 2021 14:01:35 +0100 [thread overview]
Message-ID: <CAFEAcA89zK6pET09ZuDAmOB8O0PHrycmKcWWmTfVK1Tm5wQ=LQ@mail.gmail.com> (raw)
In-Reply-To: <20210806023119.431680-1-ehabkost@redhat.com>
On Fri, 6 Aug 2021 at 03:31, Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> The SBSA_GWDT enum value conflicts with the SBSA_GWDT() QOM type
> checking helper, preventing us from using a OBJECT_DEFINE* or
> DEFINE_INSTANCE_CHECKER macro for the SBSA_GWDT() wrapper.
>
> If I understand the SBSA 6.0 specification correctly, the signal
> being connected to IRQ 16 is the WS0 output signal from the
> Generic Watchdog. Rename the enum value to SBSA_GWDT_WS0 to be
> more explicit and avoid the name conflict.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Applied to target-arm.next for 6.2, thanks.
-- PMM
prev parent reply other threads:[~2021-08-19 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 2:31 [PATCH for-6.2] sbsa-ref: Rename SBSA_GWDT enum value Eduardo Habkost
2021-08-19 13:01 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA89zK6pET09ZuDAmOB8O0PHrycmKcWWmTfVK1Tm5wQ=LQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=ehabkost@redhat.com \
--cc=leif@nuviainc.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rad@semihalf.com \
--cc=shashi.mallela@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).