From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL7Or-0005fG-9s for qemu-devel@nongnu.org; Mon, 29 Apr 2019 10:36:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL7Oq-00049H-Gx for qemu-devel@nongnu.org; Mon, 29 Apr 2019 10:36:57 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:37586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hL7Oq-00048i-2U for qemu-devel@nongnu.org; Mon, 29 Apr 2019 10:36:56 -0400 Received: by mail-oi1-x243.google.com with SMTP id k6so8471983oic.4 for ; Mon, 29 Apr 2019 07:36:55 -0700 (PDT) MIME-Version: 1.0 References: <20190328230404.12909-1-richard.henderson@linaro.org> <20190328230404.12909-29-richard.henderson@linaro.org> In-Reply-To: <20190328230404.12909-29-richard.henderson@linaro.org> From: Peter Maydell Date: Mon, 29 Apr 2019 15:36:44 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH for-4.1 v2 28/36] target/xtensa: Use env_cpu, env_archcpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: QEMU Developers On Thu, 28 Mar 2019 at 23:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > @@ -712,10 +707,15 @@ static inline int cpu_mmu_index(CPUXtensaState *env, bool ifetch) > #define XTENSA_CSBASE_LBEG_OFF_MASK 0x00ff0000 > #define XTENSA_CSBASE_LBEG_OFF_SHIFT 16 > > +typedef CPUXtensaState CPUArchState; > +typedef XtensaCPU ArchCPU; > + > +#include "exec/cpu-all.h" Shouldn't this bit be in an earlier patch ? thanks -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D37FC43219 for ; Mon, 29 Apr 2019 14:38:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0185B20656 for ; Mon, 29 Apr 2019 14:38:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aDWWtkl7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0185B20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL7QT-0006SU-9A for qemu-devel@archiver.kernel.org; Mon, 29 Apr 2019 10:38:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL7Or-0005fG-9s for qemu-devel@nongnu.org; Mon, 29 Apr 2019 10:36:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL7Oq-00049H-Gx for qemu-devel@nongnu.org; Mon, 29 Apr 2019 10:36:57 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:37586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hL7Oq-00048i-2U for qemu-devel@nongnu.org; Mon, 29 Apr 2019 10:36:56 -0400 Received: by mail-oi1-x243.google.com with SMTP id k6so8471983oic.4 for ; Mon, 29 Apr 2019 07:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d34tFGG/tSM+NquVpJ6ChfVAxq5XsCav9xPYLDw6bcc=; b=aDWWtkl7XNXBNDGxm/826rG1oZb2uENKUgo6VI/m/VEjQjiRsAhY2E31qhRDCxNFZH dDRHpl5S23pSrblcliTttKpDs2o89bwNCYTz5FWaumu7u1uRfWvfkd1Ct4s1dcP5S+Up w4ZXCn5YvWrNaQyTK52123aL97DY7/Fo2YaZw4BqlJ5z/3P51DsIHCFbiNdOyV3VXoJq yB6Oy+SYmBckaBjFiF8Tuv6i2P4yqwU4cdaJDtIp4yf9cXdrRpmUE+gYo3xTRGFbYd17 xIUnqxWxDXDFX3eh9fG8Zhu9Fyf/dshXu1B6b1uDagbKl8O/XC9uYI34ZIGv1+g4XIZu qE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d34tFGG/tSM+NquVpJ6ChfVAxq5XsCav9xPYLDw6bcc=; b=TYPWCxdFmK0nuU6QuVEAn/e0R4HADqGGM19kV+ZenqIIpKH0UDA9Gt/JSnQTtmRoB8 w49ZQJUEeAVXeomb0WOPTXoyoGJSrdHtWKLx/hB9Z1UFqNQUOj/9jXYdialrA8s6Lpin ZR8RTaDBc3exHRn8RVN+6YPsrwEpNcBffLKuxvrNqpmOGbo8kDQZbGI6wQLIXL84NNJ/ 7iHwbhk8lVHbh3Tq/h47+wwjO7UtGhxdBshwfsaCdRkbbiFrz9A5Ft3aDiBU6z5/txh4 94Q38qDdl+TwsPX6YvUjILB63pHGYW0ZdrK4RyXaVxXBc779bNsvUZS+5br3mtbBKFyP SRSA== X-Gm-Message-State: APjAAAXf/0x/I3ZoqFznmTkjzWlp9neeyYO6UvwpoYPVTw+LLOOvl04O 6bKt4BQeFGAvYno9Bc6mykjIv1WSeTvBBi7t4f0j1w== X-Google-Smtp-Source: APXvYqxV6MsjVQPbcTJKbvCJ3taucxZ5TBRIyLfacbmoetp1CZVbmVplPSv9kD41lu/PCAdUng5PoZguGV84LtQ0Ddg= X-Received: by 2002:aca:e054:: with SMTP id x81mr15837436oig.146.1556548614978; Mon, 29 Apr 2019 07:36:54 -0700 (PDT) MIME-Version: 1.0 References: <20190328230404.12909-1-richard.henderson@linaro.org> <20190328230404.12909-29-richard.henderson@linaro.org> In-Reply-To: <20190328230404.12909-29-richard.henderson@linaro.org> From: Peter Maydell Date: Mon, 29 Apr 2019 15:36:44 +0100 Message-ID: To: Richard Henderson Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 Subject: Re: [Qemu-devel] [PATCH for-4.1 v2 28/36] target/xtensa: Use env_cpu, env_archcpu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190429143644.OV_4KfCFAP0C8LFUhN8EJsCGTl02C4tyUAzWUJ5BgBw@z> On Thu, 28 Mar 2019 at 23:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > @@ -712,10 +707,15 @@ static inline int cpu_mmu_index(CPUXtensaState *env, bool ifetch) > #define XTENSA_CSBASE_LBEG_OFF_MASK 0x00ff0000 > #define XTENSA_CSBASE_LBEG_OFF_SHIFT 16 > > +typedef CPUXtensaState CPUArchState; > +typedef XtensaCPU ArchCPU; > + > +#include "exec/cpu-all.h" Shouldn't this bit be in an earlier patch ? thanks -- PMM