From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35392)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZGO6Y-0000i0-EX
	for qemu-devel@nongnu.org; Sat, 18 Jul 2015 05:08:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZGO6T-0008Fa-JR
	for qemu-devel@nongnu.org; Sat, 18 Jul 2015 05:08:22 -0400
Received: from mail-vn0-f53.google.com ([209.85.216.53]:33315)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZGO6T-0008FW-GN
	for qemu-devel@nongnu.org; Sat, 18 Jul 2015 05:08:17 -0400
Received: by vnav141 with SMTP id v141so8498145vna.0
	for <qemu-devel@nongnu.org>; Sat, 18 Jul 2015 02:08:17 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5a39caaa44a0a2f6b9b5591fd48dd9c69f802c4e.1437197974.git.crosthwaite.peter@gmail.com>
References: <cover.1437197974.git.crosthwaite.peter@gmail.com>
	<5a39caaa44a0a2f6b9b5591fd48dd9c69f802c4e.1437197974.git.crosthwaite.peter@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sat, 18 Jul 2015 10:07:57 +0100
Message-ID: <CAFEAcA8AMWGEkOXUjnsMzZP17ZDO1uYbms3KptdhavDW-saU2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/2] arm: Remove hw_error() usages.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 18 July 2015 at 07:00, Peter Crosthwaite <crosthwaitepeter@gmail.com> wrote:
> All of these hw_errors are fatal and indicate something wrong with
> QEMU implementation.
>
> Convert to g_assert_not_reached.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> Dropped the error messages as they are not hugely useful outside of
> a debug flow.
> ---
>  target-arm/cpu.c    | 4 ++--
>  target-arm/helper.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-arm/cpu.c b/target-arm/cpu.c
> index c4b8448..8b5471a 100644
> --- a/target-arm/cpu.c
> +++ b/target-arm/cpu.c
> @@ -325,7 +325,7 @@ static void arm_cpu_set_irq(void *opaque, int irq, int level)
>          }
>          break;
>      default:
> -        hw_error("arm_cpu_set_irq: Bad interrupt line %d\n", irq);
> +        g_assert_not_reached();
>      }
>  }
>
> @@ -344,7 +344,7 @@ static void arm_cpu_kvm_set_irq(void *opaque, int irq, int level)
>          kvm_irq |= KVM_ARM_IRQ_CPU_FIQ;
>          break;
>      default:
> -        hw_error("arm_cpu_kvm_set_irq: Bad interrupt line %d\n", irq);
> +        g_assert_not_reached();

We should be consistent between this and arm_cpu_set_irq()
about whether we assert or LOG_UNIMP the VIRQ/VFIQ cases.
I'm happy for them all to assert.

>      }
>      kvm_irq |= cs->cpu_index << KVM_ARM_IRQ_VCPU_SHIFT;
>      kvm_set_irq(kvm_state, kvm_irq, level ? 1 : 0);
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index b2f3db9..662e2bb 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -3997,7 +3997,7 @@ int bank_number(int mode)
>      case ARM_CPU_MODE_MON:
>          return 7;
>      }
> -    hw_error("bank number requested for bad CPSR mode value 0x%x\n", mode);
> +    g_assert_not_reached();
>  }
>
>  void switch_mode(CPUARMState *env, int mode)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM