From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZH8bi-0006Qd-SV for qemu-devel@nongnu.org; Mon, 20 Jul 2015 06:47:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZH8be-0001hu-Pt for qemu-devel@nongnu.org; Mon, 20 Jul 2015 06:47:38 -0400 Received: from mail-vn0-f43.google.com ([209.85.216.43]:36596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZH8be-0001hm-MV for qemu-devel@nongnu.org; Mon, 20 Jul 2015 06:47:34 -0400 Received: by vnk197 with SMTP id 197so21365373vnk.3 for ; Mon, 20 Jul 2015 03:47:34 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1437208027-14584-1-git-send-email-sw@weilnetz.de> From: Peter Maydell Date: Mon, 20 Jul 2015 11:47:14 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH for-2.4] disas/arm-a64: Add missing compiler attribute GCC_FMT_ATTR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Trivial , QEMU Developer On 18 July 2015 at 10:13, Peter Maydell wrote: > On 18 July 2015 at 09:27, Stefan Weil wrote: >> Type fprintf_function which fits here was defined with this attribute. >> >> Signed-off-by: Stefan Weil >> --- >> >> This is an optional trivial patch for 2.4 which fixes compiler warnings >> in my build environment (with -Wextra). > > Reviewed-by: Peter Maydell > > No objection if you want to put it in 2.4, though I'm a bit > surprised that missing GCC_FMT_ATTR provokes warnings. > The cleanup is nice anyway. I've applied this to target-arm.next. Thanks. -- PMM