Re: [Qemu-devel] [PATCH] disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers

[Peter Maydell <peter.maydell@linaro.org>]

On 19 July 2016 at 15:17, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Tue, Jul 19, 2016 at 03:04:36PM +0100, Peter Maydell wrote:
>> disas/bfd.h defines ATTRIBUTE_UNUSED, but unfortunately the
>> ALSA system headers also define this macro, which means that
>> you can get a compilation failure if building with ALSA and
>> any files happen to include the alsa headers before bfd.h
>> rather than the other way around.
>>
>> This is unfortunate namespace pollution by the ALSA headers but
>> we can work around it. Add an #ifndef guard to bfd.h and remove
>> the unnecessary extra definition in disas/arm.c to fix this.
>>
>> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>>  disas/arm.c         | 1 -
>>  include/disas/bfd.h | 2 ++
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks; applied to master as a buildfix.

-- PMM