qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Thomas Huth <thuth@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	 "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: test_x86_64_hotplug_cpu.py times out frequently in CI
Date: Mon, 6 Jan 2025 16:49:22 +0000	[thread overview]
Message-ID: <CAFEAcA8C916fiLab_86JhXMe5sjVQBjFZQVCP6YP+715pn9qLQ@mail.gmail.com> (raw)
In-Reply-To: <CAJSP0QW02Mf5Vtp9UbvAUc+UXKV0Exw_ggFCMAgVQ0+dH7Jf0w@mail.gmail.com>

On Mon, 6 Jan 2025 at 16:45, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
> Hi Thomas,
> test_x86_64_hotplug_cpu.py times out frequently in CI runs. Here is an example:
> https://gitlab.com/qemu-project/qemu/-/jobs/8777540230#L1151
>
> The detailed test logs are here:
> https://gitlab.com/qemu-project/qemu/-/jobs/8777540230/artifacts/browse/build/tests/functional/x86_64/test_x86_64_hotplug_cpu.HotPlugCPU.test_hotplug/
>
> I looked at this failure with Dan and Peter on IRC. It was pointed out
> that the final command assumes that device_del takes effect
> immediately. The console log shows that the CPU was still visible to
> the guest when the final command executed.
>
> Could be a bug in QEMU, the test, or both?
>
> 2025-01-06 15:45:29,308: :/#
> 2025-01-06 15:45:29,313: cd /sys/devices/system/cpu/cpu0
> 2025-01-06 15:45:29,315: :/sys/devices/system/cpu/cpu0#
> 2025-01-06 15:45:29,320: cd /sys/devices/system/cpu/cpu1
> 2025-01-06 15:45:29,322: sh: cd: /sys/devices/system/cpu/cpu1: No such
> file or directory
> 2025-01-06 15:45:29,325:
> 2025-01-06 15:45:29,330: :/sys/devices/system/cpu/cpu0# [    7.337146]
> CPU1 has been hot-added
> 2025-01-06 15:45:29,330:
> 2025-01-06 15:45:29,335: cd /sys/devices/system/cpu/cpu1
> 2025-01-06 15:45:29,337: :/sys/devices/system/cpu/cpu1#
> 2025-01-06 15:45:29,342: cd /sys/devices/system/cpu/cpu1

Though the fact that there is no final shell prompt after
the last 'cd' command is perhaps evidence against this being
a simple race where the guest execution of the "cd" command
beat the guest handling of the hot-unplug event.

-- PMM


  reply	other threads:[~2025-01-06 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 16:45 test_x86_64_hotplug_cpu.py times out frequently in CI Stefan Hajnoczi
2025-01-06 16:49 ` Peter Maydell [this message]
2025-01-07  9:01   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8C916fiLab_86JhXMe5sjVQBjFZQVCP6YP+715pn9qLQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).