From: Peter Maydell <peter.maydell@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] pl110: Implement vertical compare/next base interrupts
Date: Thu, 25 Jan 2018 11:33:37 +0000 [thread overview]
Message-ID: <CAFEAcA8CHWkHwkXYsfKMwH_UVFGhs+0ZEdvXX_j8JFxSfU4nfw@mail.gmail.com> (raw)
In-Reply-To: <20180123225654.5764-1-linus.walleij@linaro.org>
On 23 January 2018 at 22:56, Linus Walleij <linus.walleij@linaro.org> wrote:
> This implements rudimentary support for interrupt generation on the
> PL110. I am working on a new DRI/KMS driver for Linux and since that
> uses the blanking interrupt, we need something to fire here. Without
> any interrupt support Linux waits for a while and then gives ugly
> messages about the vblank not working in the console (it does not
> hang perpetually or anything though, DRI is pretty forgiving).
>
> I solved it for now by setting up a timer to fire at 60Hz and pull
> the interrupts for "vertical compare" and "next memory base"
> at this interval. This works fine and fires roughly the same number
> of IRQs on QEMU as on the hardware and leaves the console clean
> and nice.
>
> People who want to create more accurate emulation can probably work
> on top of this if need be. It is certainly closer to the hardware
> behaviour than what we have today anyway.
Yeah, I think that "fire every 60Hz" is good enough for now.
Applied to target-arm.next (with the long lines checkpatch
complains about folded).
thanks
-- PMM
prev parent reply other threads:[~2018-01-25 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 22:56 [Qemu-devel] [PATCH] pl110: Implement vertical compare/next base interrupts Linus Walleij
2018-01-23 23:05 ` no-reply
2018-01-25 11:33 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8CHWkHwkXYsfKMwH_UVFGhs+0ZEdvXX_j8JFxSfU4nfw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).