From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: Artyom Tarasenko <atar4qemu@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing
Date: Tue, 24 Jan 2017 09:55:14 +0000 [thread overview]
Message-ID: <CAFEAcA8CKZRcGSCrtBvPykh2Z4wCXyHd3ct=wk8jV=dh1uMp1g@mail.gmail.com> (raw)
In-Reply-To: <87pojcx3zd.fsf@dusky.pond.sub.org>
On 24 January 2017 at 08:21, Markus Armbruster <armbru@redhat.com> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>> PS: doesn't this break 'make check' if the rom files
>> are missing?
>
> Yes, it does. Obvious incremental fix appended. It still prints
> rom_add_file()'s message. Swap the operands of && to get rid of it.
Yes, we should do this with
(!qtest_enabled && rom_add_file_fixed(file, addr, -1))
to avoid printing the warnings in the make check output.
thanks
-- PMM
prev parent reply other threads:[~2017-01-24 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 21:21 [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing Artyom Tarasenko
2017-01-23 22:17 ` Peter Maydell
2017-01-23 22:18 ` Peter Maydell
2017-01-24 8:21 ` Markus Armbruster
2017-01-24 9:32 ` Artyom Tarasenko
2017-01-24 9:55 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8CKZRcGSCrtBvPykh2Z4wCXyHd3ct=wk8jV=dh1uMp1g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).