From: Peter Maydell <peter.maydell@linaro.org>
To: tobias.roehmel@rwth-aachen.de
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/9] Add ARM Cortex-R52 cpu
Date: Tue, 27 Sep 2022 17:31:08 +0100 [thread overview]
Message-ID: <CAFEAcA8CMUC6_zi2SFdV7Gomsjm_mK2T3hPZ1-t0Ahn+R92NCA@mail.gmail.com> (raw)
In-Reply-To: <20220820141914.217399-1-tobias.roehmel@rwth-aachen.de>
On Sat, 20 Aug 2022 at 15:19, <tobias.roehmel@rwth-aachen.de> wrote:
>
> From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
>
> Thanks for the review!
> Here is v3:
>
> v3:
> PATCH 2 (Don't add all MIDR aliases for cores that immplement PMSA):
> fixed the comment and changed to single element instead of array.
> Also the alias is not added for all PMSA CPUs as Peter suggested.
> PATCH 3 (Make RVBAR available for all ARMv8 CPUs):
> Added the missing RVBAR register as alias to RVBAR_ELx.
> Tested that this code actually takes the lower 32 bits
> of RVBAR_ELx as RVBAR.
Hi -- sorry it's taken me so long to get to this, but I had
a combination of holiday and KVM Forum :-( Anyway, I've now
completed my review pass for v3.
thanks
-- PMM
prev parent reply other threads:[~2022-09-27 16:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 14:19 [PATCH v3 0/9] Add ARM Cortex-R52 cpu tobias.roehmel
2022-08-20 14:19 ` [PATCH v3 1/9] target/arm: Add ARM_FEATURE_V8_R tobias.roehmel
2022-08-20 14:19 ` [PATCH v3 2/9] target/arm: Don't add all MIDR aliases for cores that immplement PMSA tobias.roehmel
2022-09-27 16:29 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 3/9] target/arm: Make RVBAR available for all ARMv8 CPUs tobias.roehmel
2022-09-27 13:01 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 4/9] target/arm: Make stage_2_format for cache attributes optional tobias.roehmel
2022-09-27 12:52 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 5/9] target/arm: Add ARMCacheAttrs to the signature of pmsav8_mpu_lookup tobias.roehmel
2022-09-27 13:05 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 6/9] target/arm: Enable TTBCR_EAE for ARMv8-R AArch32 tobias.roehmel
2022-09-27 13:20 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 7/9] target/arm: Add PMSAv8r registers tobias.roehmel
2022-09-27 13:50 ` Peter Maydell
2022-10-15 13:07 ` Tobias Roehmel
2022-10-20 15:02 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 8/9] target/arm: Add PMSAv8r functionality tobias.roehmel
2022-09-27 16:23 ` Peter Maydell
2022-08-20 14:19 ` [PATCH v3 9/9] target/arm: Add ARM Cortex-R52 cpu tobias.roehmel
2022-09-27 16:31 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8CMUC6_zi2SFdV7Gomsjm_mK2T3hPZ1-t0Ahn+R92NCA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tobias.roehmel@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).