From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: "Rob Herring" <rob.herring@linaro.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] ahci: fix sysbus support
Date: Tue, 18 Mar 2014 15:46:17 +0000 [thread overview]
Message-ID: <CAFEAcA8CWAqVOfUbyWRUZRYd1sgD9nTy9mTpm42su5NK4MzCmA@mail.gmail.com> (raw)
In-Reply-To: <1392073373-3295-1-git-send-email-robherring2@gmail.com>
On 10 February 2014 23:02, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@linaro.org>
>
> Non-PCI AHCI support is broken due to assertion failures when trying
> to convert AHCIState to a PCIDevice pointer as AHCIState can have
> different container structs. Fix this by using the non-asserting object
> cast and checking the returned pointer is not NULL.
>
> The AddressSpace pointer is also being initialized to NULL and causing
> dma_memory_map call to fail. Fix this by initializing to
> address_space_memory for sysbus instances.
>
> Also correct AHCI_VMSTATE to use the correct container SysbusAHCIState
> for sysbus instances.
>
> Signed-off-by: Rob Herring <rob.herring@linaro.org>
Andreas just confirmed on IRC that the cast syntax you've
used is fine, so I'll take this into target-arm.next
(since Highbank is the only user of sysbus-ahci). I
expect to get this into rc1.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
prev parent reply other threads:[~2014-03-18 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 23:02 [Qemu-devel] [PATCH] ahci: fix sysbus support Rob Herring
2014-02-11 0:32 ` Peter Maydell
2014-03-18 0:11 ` Rob Herring
2014-03-18 7:28 ` Paolo Bonzini
2014-03-18 15:46 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8CWAqVOfUbyWRUZRYd1sgD9nTy9mTpm42su5NK4MzCmA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=rob.herring@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).