From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WPwE0-0004lU-83
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 11:46:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WPwDv-00040q-9b
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 11:46:44 -0400
Received: from mail-la0-f45.google.com ([209.85.215.45]:34124)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WPwDv-00040R-3l
	for qemu-devel@nongnu.org; Tue, 18 Mar 2014 11:46:39 -0400
Received: by mail-la0-f45.google.com with SMTP id hr17so4866181lab.4
	for <qemu-devel@nongnu.org>; Tue, 18 Mar 2014 08:46:38 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1392073373-3295-1-git-send-email-robherring2@gmail.com>
References: <1392073373-3295-1-git-send-email-robherring2@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 18 Mar 2014 15:46:17 +0000
Message-ID: <CAFEAcA8CWAqVOfUbyWRUZRYd1sgD9nTy9mTpm42su5NK4MzCmA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] ahci: fix sysbus support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Rob Herring <rob.herring@linaro.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>

On 10 February 2014 23:02, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@linaro.org>
>
> Non-PCI AHCI support is broken due to assertion failures when trying
> to convert AHCIState to a PCIDevice pointer as AHCIState can have
> different container structs. Fix this by using the non-asserting object
> cast and checking the returned pointer is not NULL.
>
> The AddressSpace pointer is also being initialized to NULL and causing
> dma_memory_map call to fail. Fix this by initializing to
> address_space_memory for sysbus instances.
>
> Also correct AHCI_VMSTATE to use the correct container SysbusAHCIState
> for sysbus instances.
>
> Signed-off-by: Rob Herring <rob.herring@linaro.org>

Andreas just confirmed on IRC that the cast syntax you've
used is fine, so I'll take this into target-arm.next
(since Highbank is the only user of sysbus-ahci). I
expect to get this into rc1.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM