From: Peter Maydell <peter.maydell@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
QEMU Developers <qemu-devel@nongnu.org>,
Greg Kurz <groug@kaod.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10
Date: Mon, 24 Apr 2017 22:46:07 +0100 [thread overview]
Message-ID: <CAFEAcA8CWYCxVauuWSsmuQw4YG1O0DO+rYASm2aVhirp3Z3mZA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1704241423030.16723@sstabellini-ThinkPad-X260>
On 24 April 2017 at 22:25, Stefano Stabellini <sstabellini@kernel.org> wrote:
> diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h
> new file mode 100644
> index 0000000..18f0ec0
> --- /dev/null
> +++ b/hw/9pfs/xen-9pfs.h
> @@ -0,0 +1,14 @@
> +/*
> + * Xen 9p backend
> + *
> + * Copyright Aporeto 2017
> + *
> + * Authors:
> + * Stefano Stabellini <stefano@aporeto.com>
> + *
> + */
Trivial file, but I prefer it if we have a brief license
statement in every file, just to be clear (it might
accumulate more code later).
> +
> +#include <xen/io/protocols.h>
> +#include "hw/xen/io/ring.h"
> +
> +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs);
Is it worth a comment to dissuade people from thinking they can
inline the file back into xen-9p-backend.c ?
thanks
-- PMM
next prev parent reply other threads:[~2017-04-24 21:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 20:14 [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10 Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 01/21] xen: make use of xen_xc implicit in xen_common.h inlines Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 02/21] xen: rename xen_modified_memory() to xen_hvm_modified_memory() Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 03/21] xen: create wrappers for all other uses of xc_hvm_XXX() functions Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 04/21] configure: detect presence of libxendevicemodel Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 05/21] xen: use libxendevicemodel when available Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 06/21] xen: use 5 digit xen versions Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 07/21] xen: use libxendevice model to restrict operations Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 08/21] xen: additionally restrict xenforeignmemory operations Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 09/21] configure: use pkg-config for obtaining xen version Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 10/21] xen: import ring.h from xen Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 11/21] 9p: introduce a type for the 9p header Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 12/21] xen/9pfs: introduce Xen 9pfs backend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 13/21] xen/9pfs: connect to the frontend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 14/21] xen/9pfs: receive requests from " Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 15/21] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 16/21] xen/9pfs: send responses back to the frontend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 17/21] xen/9pfs: build and register Xen 9pfs backend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 18/21] add xen-9p-backend to MAINTAINERS under Xen Stefano Stabellini
2017-04-21 20:15 ` [Qemu-devel] [PULL 19/21] move xen-common.c to hw/xen/ Stefano Stabellini
2017-04-21 20:15 ` [Qemu-devel] [PULL 20/21] move xen-hvm.c to hw/i386/xen/ Stefano Stabellini
2017-04-21 20:15 ` [Qemu-devel] [PULL 21/21] move xen-mapcache.c " Stefano Stabellini
2017-04-24 10:31 ` [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10 Peter Maydell
2017-04-24 21:25 ` Stefano Stabellini
2017-04-24 21:46 ` Peter Maydell [this message]
2017-04-24 23:44 ` Stefano Stabellini
2017-04-25 6:44 ` Greg Kurz
2017-04-25 7:31 ` Markus Armbruster
2017-04-25 17:18 ` Stefano Stabellini
2017-04-26 6:44 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8CWYCxVauuWSsmuQw4YG1O0DO+rYASm2aVhirp3Z3mZA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).