From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: hangaohuai@huawei.com,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhao@linaro.org>,
Shannon Zhao <zhaoshenglong@huawei.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends
Date: Tue, 28 Apr 2015 14:16:40 +0100 [thread overview]
Message-ID: <CAFEAcA8Ch9iCfTmudGS+BmxghNxSE4CvBdy0q4bZOEsUyMC8CA@mail.gmail.com> (raw)
In-Reply-To: <20150428151249-mutt-send-email-mst@redhat.com>
On 28 April 2015 at 14:13, Michael S. Tsirkin <mst@redhat.com> wrote:
> The patches look correct to me too, but I want s390
> cleaned up so it does not include COMMON_FEATURES
> in 100 places, and I prefer merging it all together.
It seems a bit harsh to ask Shannon to do s390 cleanup when
he doesn't have any access to s390 guests or test cases...
Making S390 put COMMON_FEATURES in the right places seems
to me like a separate bit of s390-specific cleanup.
(The other cleanup we could do after this patchset would
be to just expand out the DEFINE_VIRTIO_NET/RNG/SCSI/etc_FEATURES
macros which are all now used in exactly one place. But
again I think that's separate and can be done later.)
thanks
-- PMM
next prev parent reply other threads:[~2015-04-28 13:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 11:51 [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends shannon.zhao
2015-04-28 11:51 ` [Qemu-devel] [PATCH v4 1/2] virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net shannon.zhao
2015-04-28 11:51 ` [Qemu-devel] [PATCH v4 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi shannon.zhao
2015-04-28 12:48 ` [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends Michael S. Tsirkin
2015-04-28 12:52 ` Peter Maydell
2015-04-28 13:05 ` Michael S. Tsirkin
2015-04-28 13:20 ` Cornelia Huck
2015-04-28 14:03 ` Michael S. Tsirkin
2015-04-28 13:06 ` Peter Maydell
2015-04-28 13:13 ` Michael S. Tsirkin
2015-04-28 13:16 ` Peter Maydell [this message]
2015-04-28 13:24 ` Cornelia Huck
2015-04-28 14:35 ` Michael S. Tsirkin
2015-04-28 18:14 ` Michael S. Tsirkin
2015-04-28 18:32 ` Michael S. Tsirkin
2015-04-28 18:35 ` Michael S. Tsirkin
2015-04-29 8:17 ` Christian Borntraeger
2015-04-29 8:52 ` Cornelia Huck
2015-04-29 10:32 ` Michael S. Tsirkin
2015-04-29 14:33 ` Cornelia Huck
2015-04-29 18:32 ` Michael S. Tsirkin
2015-04-29 14:43 ` Christian Borntraeger
2015-04-29 18:35 ` Michael S. Tsirkin
2015-04-29 19:49 ` Christian Borntraeger
2015-04-29 20:19 ` Michael S. Tsirkin
2015-04-30 15:50 ` Christian Borntraeger
2015-04-28 18:34 ` Peter Maydell
2015-04-28 18:38 ` Michael S. Tsirkin
2015-04-29 9:55 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Ch9iCfTmudGS+BmxghNxSE4CvBdy0q4bZOEsUyMC8CA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=hangaohuai@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).