From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46423)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1X7NuN-0007Ws-Bb
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 08:02:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1X7NuH-0006zl-C8
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 08:02:03 -0400
Received: from mail-lb0-f182.google.com ([209.85.217.182]:57809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1X7NuH-0006zT-5P
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 08:01:57 -0400
Received: by mail-lb0-f182.google.com with SMTP id z11so552926lbi.41
	for <qemu-devel@nongnu.org>; Wed, 16 Jul 2014 05:01:56 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <87a989psop.fsf@linaro.org>
References: <1405091884-29955-1-git-send-email-Joakim.Tjernlund@transmode.se>
	<1405091884-29955-5-git-send-email-Joakim.Tjernlund@transmode.se>
	<CAFEAcA-qU3Q+936fVB3QEcK23k1cyeknKOHB61A0sH+-F=tXPA@mail.gmail.com>
	<OFC4B69804.DD059A4F-ONC1257D12.0063EF91-C1257D12.00644BB8@transmode.se>
	<CAFEAcA-fek_z4UKsHyxmiWDxJV6rhCxonxO3g4DbfjrUXoRC5Q@mail.gmail.com>
	<53C083B9.2040506@suse.de>
	<OF55D46D1C.2648148E-ONC1257D13.002E0845-C1257D13.002E39D2@transmode.se>
	<87a989psop.fsf@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 16 Jul 2014 13:01:35 +0100
Message-ID: <CAFEAcA8Cmt_wRQJg_dKQDKZWE+oFULm6+AkcaWHOndX6Ei9BCQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive
	logging
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, Joakim Tjernlund <joakim.tjernlund@transmode.se>, Alexander Graf <agraf@suse.de>

On 16 July 2014 10:17, Alex Benn=C3=A9e <alex.bennee@linaro.org> wrote:
> On aarch64 we do:
>
> #define unsupported_encoding(s, insn)                                    =
\
>     do {                                                                 =
\
>         qemu_log_mask(LOG_UNIMP,                                         =
\
>                       "%s:%d: unsupported instruction encoding 0x%08x "  =
\
>                       "at pc=3D%016" PRIx64 "\n",                        =
  \
>                       __FILE__, __LINE__, insn, s->pc - 4);              =
\
>         unallocated_encoding(s);                                         =
\
>     } while (0);
>
> So we signal it's unimplemented before falling through to the signal
> generating code.

Yes, but that macro is only for instructions which exist but which
QEMU doesn't implement, not for instructions which exist and
which we do have an implementation of but which we generate an
exception for because they aren't present on this particular CPU.
That's a separate issue from whether you might want to optionally
log every SIGILL a process generates.

thanks
-- PMM