From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: John Snow <jsnow@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Qemu-block <qemu-block@nongnu.org>
Subject: [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error
Date: Thu, 27 Aug 2015 16:17:59 +0100 [thread overview]
Message-ID: <CAFEAcA8CpHkkVi9_BUomseA1mB+6au2ybfdAxKC9D3V6T0eD4Q@mail.gmail.com> (raw)
I've noticed recently that tests/hd-geo-test.c creates test disk
images which are 4GB in size, which is a problem if the filesystem
on the host doesn't support sparse files. In particular, OSX's HFS+
doesn't have sparse file support, and Windows probably doesn't either.
Worse, if the test fails an assertion somewhere the test doesn't
clean up after itself and leaves a 4GB file lying around in /tmp/.
It would be nice if we could skip these tests on filesystems that
don't have sparse file support...
thanks
-- PMM
next reply other threads:[~2015-08-27 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:17 Peter Maydell [this message]
2015-08-27 15:29 ` [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error Eric Blake
2015-08-27 16:48 ` John Snow
2015-08-28 13:06 ` Markus Armbruster
2015-08-31 18:54 ` John Snow
2015-08-31 19:25 ` Peter Maydell
2015-09-01 6:02 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8CpHkkVi9_BUomseA1mB+6au2ybfdAxKC9D3V6T0eD4Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).