From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUywZ-0008Ur-Vc for qemu-devel@nongnu.org; Thu, 27 Aug 2015 11:18:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUywV-0001Nr-1C for qemu-devel@nongnu.org; Thu, 27 Aug 2015 11:18:23 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:33105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUywU-0001Nb-T8 for qemu-devel@nongnu.org; Thu, 27 Aug 2015 11:18:18 -0400 Received: by vkd66 with SMTP id 66so10738829vkd.0 for ; Thu, 27 Aug 2015 08:18:18 -0700 (PDT) MIME-Version: 1.0 From: Peter Maydell Date: Thu, 27 Aug 2015 16:17:59 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: John Snow , Markus Armbruster , Qemu-block I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+ doesn't have sparse file support, and Windows probably doesn't either. Worse, if the test fails an assertion somewhere the test doesn't clean up after itself and leaves a 4GB file lying around in /tmp/. It would be nice if we could skip these tests on filesystems that don't have sparse file support... thanks -- PMM