From: Peter Maydell <peter.maydell@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Peter Chubb <peter.chubb@nicta.com.au>,
QEMU Developers <qemu-devel@nongnu.org>,
Jean-Christophe Dubois <jcd@tribudubois.net>
Subject: Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support
Date: Thu, 21 May 2020 22:04:38 +0100 [thread overview]
Message-ID: <CAFEAcA8DfoR3EUHn2J4D8BNR9Ms27R-uR7q7BnXuwOFFbGgZdw@mail.gmail.com> (raw)
In-Reply-To: <20200517162135.110364-3-linux@roeck-us.net>
On Sun, 17 May 2020 at 17:21, Guenter Roeck <linux@roeck-us.net> wrote:
>
> Implement full support for the watchdog in i.MX systems.
> Pretimeout support is optional because the watchdog hardware
> on i.MX31 does not support pretimeouts.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> +static Property imx2_wdt_properties[] = {
> + DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
> + false),
> +};
This Property array is missing the DEFINE_PROP_END_OF_LIST()
terminator entry, which makes QEMU crash on startup on
various host architectures but not x86-64, presumably by
random luck meaning there's some zeros after it there.
I'm going to fix up the version of this commit in my tree.
thanks
-- PMM
next prev parent reply other threads:[~2020-05-21 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 16:21 [PATCH v3 0/8] hw/arm: Implement i.MX watchdog support Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 1/8] hw: Move i.MX watchdog driver to hw/watchdog Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support Guenter Roeck
2020-05-21 21:04 ` Peter Maydell [this message]
2020-05-21 22:11 ` Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 3/8] hw/arm/fsl-imx25: Wire up watchdog Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 4/8] hw/arm/fsl-imx31: " Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 5/8] hw/arm/fsl-imx6: Connect watchdog interrupts Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 6/8] hw/arm/fsl-imx6ul: " Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 7/8] hw/arm/fsl-imx7: Instantiate various unimplemented devices Guenter Roeck
2020-05-17 16:21 ` [PATCH v3 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts Guenter Roeck
2020-05-21 15:59 ` [PATCH v3 0/8] hw/arm: Implement i.MX watchdog support Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8DfoR3EUHn2J4D8BNR9Ms27R-uR7q7BnXuwOFFbGgZdw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=jcd@tribudubois.net \
--cc=linux@roeck-us.net \
--cc=peter.chubb@nicta.com.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).