From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UUF6F-0007mI-7O
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:40:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UUF6D-00052f-T0
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:39:59 -0400
Received: from mail-lb0-f169.google.com ([209.85.217.169]:41140)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UUF6D-00051Q-Kz
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:39:57 -0400
Received: by mail-lb0-f169.google.com with SMTP id p11so5563816lbi.0
	for <qemu-devel@nongnu.org>; Mon, 22 Apr 2013 04:39:56 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1366063976-4909-12-git-send-email-imammedo@redhat.com>
References: <1366063976-4909-1-git-send-email-imammedo@redhat.com>
	<1366063976-4909-12-git-send-email-imammedo@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 22 Apr 2013 12:39:36 +0100
Message-ID: <CAFEAcA8EADah4GYEzaVcL0rdpwkNszgRDO7SpGqKdaxvmRZv8w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 11/16] introduce ICC bus/device/bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net

On 15 April 2013 23:12, Igor Mammedov <imammedo@redhat.com> wrote:
> ... to provide hotplug-able bus.
>
> * icc-bridge will serve as a parent for icc-bus and provide
>   mmio mapping services to child icc-devices.
> * icc-device will replace SysBusDevice as a parent of APIC
>   and IOAPIC devices.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2:
>   * Rebase on top the last HW reorganization series.
>   * Move hw/icc_bus.c into hw/cpu/ and hw/icc_bus.h include/hw/i386/

This seems inconsistent. I think the header should be in
include/hw/cpu/ to match the location of the .c file.

thanks
-- PMM