From: Peter Maydell <peter.maydell@linaro.org>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
qemu-devel@nongnu.org, Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH] pci: fix overflow in printf string formatting
Date: Tue, 31 May 2022 10:47:35 +0100 [thread overview]
Message-ID: <CAFEAcA8ENs6P6WU8iaPty7-QfZrBAZrhm4DeegUUjGuL4f3UUQ@mail.gmail.com> (raw)
In-Reply-To: <20220531092540.10151-2-cfontana@suse.de>
On Tue, 31 May 2022 at 10:34, Claudio Fontana <cfontana@suse.de> wrote:
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
It would be helpful to note in the commit message how
bad the overflow is, in what situations it can happen,
and how it was detected.
thanks
-- PMM
next prev parent reply other threads:[~2022-05-31 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 9:25 [PATCH] pci: fix overflow in printf string formatting Claudio Fontana
2022-05-31 9:25 ` Claudio Fontana
2022-05-31 9:47 ` Peter Maydell [this message]
2022-05-31 9:55 ` Claudio Fontana
2022-05-31 10:12 ` Claudio Fontana
2022-05-31 10:26 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8ENs6P6WU8iaPty7-QfZrBAZrhm4DeegUUjGuL4f3UUQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=cfontana@suse.de \
--cc=dfaggioli@suse.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).