From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WUghG-0005Rc-Cf
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 14:12:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WUghA-0005yg-8C
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 14:12:34 -0400
Received: from mail-la0-f43.google.com ([209.85.215.43]:61434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WUghA-0005wv-1Q
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 14:12:28 -0400
Received: by mail-la0-f43.google.com with SMTP id e16so6219712lan.30
	for <qemu-devel@nongnu.org>; Mon, 31 Mar 2014 11:12:27 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5339AED5.8010101@gmail.com>
References: <1395866754-18673-1-git-send-email-tommusta@gmail.com>
	<1395866754-18673-2-git-send-email-tommusta@gmail.com>
	<CAFEAcA-GPR6z7epxHyzW8TbAinM5mXXm9VyZc=MenbViUrpz0A@mail.gmail.com>
	<5339AED5.8010101@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 31 Mar 2014 19:12:06 +0100
Message-ID: <CAFEAcA8EP8ht8gXAK8ALYDW2aNhGQQRNvNMJ9yBUuo-zFOsp-w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/9] softfloat: Introduce
	float32_to_uint64_round_to_zero
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 31 March 2014 19:07, Tom Musta <tommusta@gmail.com> wrote:
> On 3/31/2014 12:48 PM, Peter Maydell wrote:
>> So, float64_to_uint64_round_to_zero() works by temporarily
>> fiddling with the rounding mode and then calling
>> float64_to_uint64(). Is there a reason for doing this
>> function like this rather than in the same way?

> True.  But not all of the *_round_to_zero() routines do this, e.g.
> float32_to_int64_round_to_zero().  So no matter what I do, it is
> inconsistent with something.
>
> Do you prefer the fiddle-and-reuse approach?  (I think I do, actually).
> If so, I will respin the patch.

I think that would be easier to review for correctness :-)

thanks
-- PMM