From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 233CAC433DB for ; Mon, 4 Jan 2021 11:50:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 766EC221F9 for ; Mon, 4 Jan 2021 11:50:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 766EC221F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwONZ-0008Lh-Qb for qemu-devel@archiver.kernel.org; Mon, 04 Jan 2021 06:50:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwOMA-0007TN-J2 for qemu-devel@nongnu.org; Mon, 04 Jan 2021 06:49:02 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:40989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwOM6-0004SC-VP for qemu-devel@nongnu.org; Mon, 04 Jan 2021 06:49:02 -0500 Received: by mail-ed1-x52c.google.com with SMTP id i24so27011679edj.8 for ; Mon, 04 Jan 2021 03:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fKCnx/I9P/UrRwpnQl2g55m3YR0ss5fvnhnmrp8Uk5A=; b=Z8mBiAxlBIZbUCAgEdZsIJv5ggsF9z4K6AI7nGMT44ZgCh5Mr3kRreBjTpnhmqQcCD ro15gS+4ZmSFu6bFaOO9SJCnsjBROiEYzXDd3D3a0/ofoskbg5Ku1las+D1cf57UmMZA tZKYkczvkfLgUSw/Pa6AnjSebDhWWchSh9EkzQTnYNUXbD8e4f2ecmadY3zRGx0WNP0y 5ZmcwvFOBXtA+K/KBrMWZHPr1rhvb7OuqE8lE9tBqFoRdohC9b9xkd06ydXT+7PQuAA+ 2z2Ml5BWvRrG9Ip4Ycp3ImKlbOIUlMaWOPAURzuwAtDHmz7n4/6XjgB3SIa66L+gIlLm I8vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fKCnx/I9P/UrRwpnQl2g55m3YR0ss5fvnhnmrp8Uk5A=; b=R05owUFx99KcQjAAljP7bVfgOzXuYH9Qgnn9feUBsypYdRiCwt+dZ0eZKNoifzEgj7 YaLJ6g89tVvAn44ekfWDwQwxF9kYandY3ar+VJmNvA9b0exqhFBatI8KAbc5/0OXfqWW 8fG78NgWk8KglD6bYLmXoFCciIZnRFWES+WYFCC7lPglR3KGk92DD2drDL2EB+TsxdXk xZdQ/EP1fMnprm6tWhwUSuXv1FI2askTbCoDRLrhT96VD1YgM8uy43+neNQI/7niWcAN PoZh/K+Es9O5XjzKY3Iu/edJIqgxCXchiLjPGlmD+7/Pv8HEFa62Vl6LZhrI0K9au1VX swYQ== X-Gm-Message-State: AOAM5322PXSLYkpPOkHdo8jaGOjZ+u24xdJfIxbhyHNXdWy1E1U0NnTe 9V1LVF6/8ia8Majnuai7dtTblp9Hdb/BouOWJGtsQw== X-Google-Smtp-Source: ABdhPJwAuoJdCT+Vvl+yzSfH6cu9jGxgUdPK9NytRBUkVOmbAIIdeObu9EnzSKc5ceSMDWOZbUIM44YRQjCbCeNfG9c= X-Received: by 2002:aa7:cdc3:: with SMTP id h3mr15586134edw.52.1609760937015; Mon, 04 Jan 2021 03:48:57 -0800 (PST) MIME-Version: 1.0 References: <41b3af5a-2f2b-41eb-98f1-909e80b26ff@eik.bme.hu> In-Reply-To: <41b3af5a-2f2b-41eb-98f1-909e80b26ff@eik.bme.hu> From: Peter Maydell Date: Mon, 4 Jan 2021 11:48:45 +0000 Message-ID: Subject: Re: [PATCH v2 2/3] sam460ex: Remove FDT_PPC dependency from KConfig To: BALATON Zoltan Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-ppc , QEMU Developers , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 4 Jan 2021 at 01:51, BALATON Zoltan wrote: > Something is still not right with this, I've noticed that a few other > boards also have this option selected but they don't need fdt.o that's > gated by this option in meson.build. That fdt.o is only needed by PSERIES > and POWERNV but removing FDT_PPC from other boards I get: > > ../hw/ppc/sam460ex.c:43:10: fatal error: libfdt.h: No such file or directory > #include > > so apparently this switch also pulls in the necessary CPPFLAGS or libfdt > dependency. Is there a separate switch for that or we can only get it with > fdt.o. Not a big deal just not trivial why we need an option that at first > sight select a source file which we don't need. I think I'll drop this > patch for now when resending the series. This happens because hw/ppc/meson.build does: ppc_ss.add(when: 'CONFIG_FDT_PPC', if_true: [files( 'fdt.c', ), fdt]) ie if CONFIG_FDT_PPC is set then both * add fdt.c to the build * add the 'fdt' dependency (which brings in the CFLAGS and LDFLAGS necessary for libfdt). So yes, at the moment for PPC there are only two options: * board doesn't use FDT at all * board uses FDT and gets hw/ppc/fdt.c linked in even if it doesn't use the functions there Since fdt.c currently has just one not very large function (which is only even present if TARGET_PPC64) this doesn't seem like a big deal, but in theory the "need libfdt" and "need fdt.c" parts could be decoupled. thanks -- PMM