From: Peter Maydell <peter.maydell@linaro.org>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
xin.zeng@intel.com
Subject: Re: [PATCH v2 0/3] drop writes to read-only ram device & vfio regions
Date: Fri, 3 Apr 2020 13:53:12 +0100 [thread overview]
Message-ID: <CAFEAcA8F9AUo+2VfbB-YaJxRfE+TPb76fppWfWm6c+XfQV560A@mail.gmail.com> (raw)
In-Reply-To: <20200403165657.20566-1-yan.y.zhao@intel.com>
On Fri, 3 Apr 2020 at 09:13, Yan Zhao <yan.y.zhao@intel.com> wrote:
>
> patch 1 modifies handler of ram device memory regions to drop guest writes
> to read-only ram device memory regions
>
> patch 2 modifies handler of non-mmap'd read-only vfio regions to drop guest
> writes to those regions
>
> patch 3 let mmap'd read-only vfio regions be able to generate vmexit for
> guest write. so, without patch 1, host qemu would crash on guest write to
> this read-only region. with patch 1, host qemu would drop the writes.
Just FYI, there seems to be a minor clock or timezone issue with
however you're sending these emails: the Date header you
sent reads "Date: Fri, 3 Apr 2020 16:56:57 +0000" but that
time in the UTC +0000 timezone is (as I write this) still several
hours in the future. This isn't a big deal but you probably want
to look into fixing it.
(Noticed because the wrong-date makes your patches stick to
the top of the https://patchew.org/QEMU/ list even after other
patches arrive after them.)
thanks
-- PMM
next prev parent reply other threads:[~2020-04-03 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:56 [PATCH v2 0/3] drop writes to read-only ram device & vfio regions Yan Zhao
2020-04-03 12:53 ` Peter Maydell [this message]
2020-04-07 3:15 ` Yan Zhao
2020-04-03 16:59 ` [PATCH v2 1/3] memory: drop guest writes to read-only ram device regions Yan Zhao
2020-04-03 17:00 ` [PATCH v2 2/3] hw/vfio: drop guest writes to ro regions Yan Zhao
2020-04-03 17:00 ` [PATCH v2 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Yan Zhao
2020-04-03 17:08 ` [PATCH v2 0/3] drop writes to read-only ram device & vfio regions Yan Zhao
2020-04-03 8:15 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8F9AUo+2VfbB-YaJxRfE+TPb76fppWfWm6c+XfQV560A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xin.zeng@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).