From: Peter Maydell <peter.maydell@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com Devel"
<xen-devel@lists.xensource.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/5] xen-220615
Date: Tue, 23 Jun 2015 15:52:18 +0100 [thread overview]
Message-ID: <CAFEAcA8Fo2kAGqasAVq-_EJmN8dn6MsVgcEbUChMvDDYyZu5DQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1506231128190.4824@kaball.uk.xensource.com>
On 23 June 2015 at 11:30, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Tue, 23 Jun 2015, Peter Maydell wrote:
>> I'm afraid I can't apply this -- this revert commit is missing a signed-off-by
>> line. Can you respin, please?
>
> I thought that being a straight revert, didn't need a SOB line.
> xen-220615-2 is the tag with SOB line on the last commit:
>
> git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-2
"xen/pass-through: fold host PCI command register writes"
only has Jan's signoff, not yours too... (apologies for not
noticing that first time around.)
I have a bit in my pull-request-creation script that automatically
checks that every commit has my signoff, to avoid this kind of
mistake:
https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/make-pullreq#l98
thanks
-- PMM
next prev parent reply other threads:[~2015-06-23 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 13:08 [Qemu-devel] [PULL 0/5] xen-220615 Stefano Stabellini
2015-06-22 13:09 ` [Qemu-devel] [PULL 1/5] xen/pass-through: fold host PCI command register writes Stefano Stabellini
2015-06-22 13:09 ` [Qemu-devel] [PULL 2/5] xen/pass-through: ROM BAR handling adjustments Stefano Stabellini
2015-06-22 13:09 ` [Qemu-devel] [PULL 3/5] xen/pass-through: log errno values rather than function return ones Stefano Stabellini
2015-06-22 13:09 ` [Qemu-devel] [PULL 4/5] xen/pass-through: constify some static data Stefano Stabellini
2015-06-22 13:09 ` [Qemu-devel] [PULL 5/5] Revert "xen-hvm: increase maxmem before calling xc_domain_populate_physmap" Stefano Stabellini
2015-06-23 9:37 ` [Qemu-devel] [PULL 0/5] xen-220615 Peter Maydell
2015-06-23 10:30 ` Stefano Stabellini
2015-06-23 14:52 ` Peter Maydell [this message]
2015-06-23 16:19 ` Stefano Stabellini
2015-06-23 17:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Fo2kAGqasAVq-_EJmN8dn6MsVgcEbUChMvDDYyZu5DQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).