From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7PZ6-0005Xw-9H for qemu-devel@nongnu.org; Tue, 23 Jun 2015 10:52:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7PZ0-0005mN-Fd for qemu-devel@nongnu.org; Tue, 23 Jun 2015 10:52:44 -0400 Received: from mail-vn0-f45.google.com ([209.85.216.45]:44485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7PZ0-0005m3-Bs for qemu-devel@nongnu.org; Tue, 23 Jun 2015 10:52:38 -0400 Received: by vnbg7 with SMTP id g7so1884060vnb.11 for ; Tue, 23 Jun 2015 07:52:37 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Peter Maydell Date: Tue, 23 Jun 2015 15:52:18 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 0/5] xen-220615 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com Devel" , QEMU Developers On 23 June 2015 at 11:30, Stefano Stabellini wrote: > On Tue, 23 Jun 2015, Peter Maydell wrote: >> I'm afraid I can't apply this -- this revert commit is missing a signed-off-by >> line. Can you respin, please? > > I thought that being a straight revert, didn't need a SOB line. > xen-220615-2 is the tag with SOB line on the last commit: > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-2 "xen/pass-through: fold host PCI command register writes" only has Jan's signoff, not yours too... (apologies for not noticing that first time around.) I have a bit in my pull-request-creation script that automatically checks that every commit has my signoff, to avoid this kind of mistake: https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/make-pullreq#l98 thanks -- PMM