From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtgwJ-0007DM-Ob for qemu-devel@nongnu.org; Mon, 01 Jul 2013 12:26:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtgwI-0003XW-K4 for qemu-devel@nongnu.org; Mon, 01 Jul 2013 12:26:55 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:39761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtgwI-0003X2-CD for qemu-devel@nongnu.org; Mon, 01 Jul 2013 12:26:54 -0400 Received: by mail-la0-f54.google.com with SMTP id ec20so4605080lab.13 for ; Mon, 01 Jul 2013 09:26:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <51D1AC75.3000000@redhat.com> References: <1372444009-11544-1-git-send-email-pbonzini@redhat.com> <1372444009-11544-6-git-send-email-pbonzini@redhat.com> <51D15DDC.3030705@redhat.com> <51D1AC75.3000000@redhat.com> From: Peter Maydell Date: Mon, 1 Jul 2013 17:26:32 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 1 July 2013 17:21, Paolo Bonzini wrote: > I think we should strive for one of these two: > > (1) all targets are TLS; > > (2) all targets are non-TLS if this is possible. > > Either maximizes the homogeneity across platforms. Since the two largest cases are both "cpu_single_env must be TLS" (ie (a) system emulation built with KVM support and (b) linux-user), the set of targets which can be non-TLS is really really small, and I think (1) makes much more sense. (I'm assuming you don't want to try to support cpu_single_env being both per-thread and not-per-thread in a single binary depending on whether the user passes -enable-kvm or not.) -- PMM