From: Peter Maydell <peter.maydell@linaro.org>
To: Chris Laplante <chris@laplante.io>
Cc: qemu-devel@nongnu.org, Joel Stanley <joel@jms.id.au>,
qemu-arm@nongnu.org
Subject: Re: [PATCH v2 3/6] qtest: implement named interception of out-GPIO
Date: Fri, 28 Jul 2023 10:31:28 +0100 [thread overview]
Message-ID: <CAFEAcA8GgY920QtMgj9EwjbrDey-GfiByOVGfgz-Aw7WABviYg@mail.gmail.com> (raw)
In-Reply-To: <EEsgXkv-Wn8WPzAg07I02DqCvpurTMkc4Vvb1kwHcAPi7jCW9gCRK7C0psplsefPiOL4ltRhb27ipChaC-nrnwOqNjXOjbtJCH_wwLh2_iA=@laplante.io>
On Thu, 27 Jul 2023 at 22:32, Chris Laplante <chris@laplante.io> wrote:
>
>
> > (g_strcmp0() can handle the NULL case without having
> > to special case it -- this is how qdev_get_named_gpio_list()
> > finds entries in the ngl list.)
> >
> > Apologies for not noticing that on the first round of review.
>
> No worries - it makes the code much simpler anyway. Should we bother factoring out qtest_install_gpio_out_intercept still? It is only used in one place now, as before.
I'd keep the function, I think, since you've already written
it. It's kind of usefully documenting of the intent.
-- PMM
next prev parent reply other threads:[~2023-07-28 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 3:31 [PATCH v2 0/6] Add nRF51 DETECT signal with test Chris Laplante
2023-07-26 3:31 ` [PATCH v2 1/6] hw/gpio/nrf51: implement DETECT signal Chris Laplante
2023-07-27 16:10 ` Peter Maydell
2023-07-26 3:31 ` [PATCH v2 2/6] qtest: factor out qtest_install_gpio_out_intercept Chris Laplante
2023-07-27 16:11 ` Peter Maydell
2023-07-26 3:32 ` [PATCH v2 3/6] qtest: implement named interception of out-GPIO Chris Laplante
2023-07-27 16:23 ` Peter Maydell
2023-07-27 21:32 ` Chris Laplante
2023-07-28 9:31 ` Peter Maydell [this message]
2023-07-26 3:32 ` [PATCH v2 4/6] qtest: bail from irq_intercept_in if name is specified Chris Laplante
2023-07-26 3:32 ` [PATCH v2 5/6] qtest: irq_intercept_[out/in]: return FAIL if no intercepts are installed Chris Laplante
2023-07-26 3:32 ` [PATCH v2 6/6] qtest: microbit-test: add tests for nRF51 DETECT Chris Laplante
2023-07-27 16:24 ` [PATCH v2 0/6] Add nRF51 DETECT signal with test Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8GgY920QtMgj9EwjbrDey-GfiByOVGfgz-Aw7WABviYg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=chris@laplante.io \
--cc=joel@jms.id.au \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).