From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Esteban Bosse <estebanbosse@gmail.com>,
Joaquin de Andres <me@xcancerberox.com.ar>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 6/7] hw/arm/mps2: Map the FPGA I/O block
Date: Tue, 16 Jun 2020 11:26:04 +0100 [thread overview]
Message-ID: <CAFEAcA8HKmMpgZMTuL6PSQNd2gy8h8HSvu6GwvTy8_h93teHjg@mail.gmail.com> (raw)
In-Reply-To: <20200616063157.16389-7-f4bug@amsat.org>
On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> @@ -337,6 +339,11 @@ static void mps2_common_init(MachineState *machine)
>
> sysbus_create_simple("versatile_i2c", i2cbase[i], NULL);
> }
> + sysbus_init_child_obj(OBJECT(mms), "fpgaio", &mms->fpgaio,
> + sizeof(mms->fpgaio), TYPE_MPS2_FPGAIO);
> + object_property_set_bool(OBJECT(&mms->fpgaio), true, "realized",
> + &error_fatal);
> + sysbus_mmio_map(SYS_BUS_DEVICE(&mms->fpgaio), 0, 0x40028000);
AN385 TRM isn't entirely clear but I suspect that you need to set
the FPGAIO's prescale-clk property because the default of 20MHz
isn't what the AN385 runs at. The FPGAIO model's default is written
to match the AN505, which is 20MHz, but AN385 and AN511 are both
25MHz:
https://developer.arm.com/tools-and-software/development-boards/fpga-prototyping-boards/mps2
thanks
-- PMM
next prev parent reply other threads:[~2020-06-16 10:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 6:31 [PATCH 0/7] mps2: Add few more peripherals Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 1/7] hw/arm/mps2: Rename CMSDK AHB peripheral region Philippe Mathieu-Daudé
2020-06-16 10:13 ` Peter Maydell
2020-06-16 6:31 ` [PATCH 2/7] hw/arm/mps2: Rename dualtimer as apb-dualtimer Philippe Mathieu-Daudé
2020-06-16 10:16 ` Peter Maydell
2020-06-16 6:31 ` [PATCH 3/7] hw/arm/mps2: Add CMSDK APB watchdog as unimplemented device Philippe Mathieu-Daudé
2020-06-16 10:17 ` Peter Maydell
2020-06-16 10:35 ` Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 4/7] hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices Philippe Mathieu-Daudé
2020-06-16 10:20 ` Peter Maydell
2020-06-16 6:31 ` [PATCH 5/7] hw/arm/mps2: Add I2C busses on FPGA APB Philippe Mathieu-Daudé
2020-06-16 10:21 ` Peter Maydell
2020-06-17 3:28 ` Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 6/7] hw/arm/mps2: Map the FPGA I/O block Philippe Mathieu-Daudé
2020-06-16 10:26 ` Peter Maydell [this message]
2020-06-16 10:36 ` Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons Philippe Mathieu-Daudé
2020-06-16 10:27 ` Peter Maydell
2020-06-16 10:40 ` Philippe Mathieu-Daudé
2020-06-16 12:29 ` Peter Maydell
2020-06-16 12:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8HKmMpgZMTuL6PSQNd2gy8h8HSvu6GwvTy8_h93teHjg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=estebanbosse@gmail.com \
--cc=f4bug@amsat.org \
--cc=me@xcancerberox.com.ar \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).