From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51880)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SCt70-0005ae-Ub
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:40:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SCt6u-0003Li-HC
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:40:30 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:49176)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SCt6u-0003LS-CC
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:40:24 -0400
Received: by iafj26 with SMTP id j26so1799397iaf.4
	for <qemu-devel@nongnu.org>; Wed, 28 Mar 2012 06:40:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1332782909-28412-3-git-send-email-afaerber@suse.de>
References: <1332782909-28412-1-git-send-email-afaerber@suse.de>
	<1332782909-28412-3-git-send-email-afaerber@suse.de>
Date: Wed, 28 Mar 2012 14:40:21 +0100
Message-ID: <CAFEAcA8HT+_u_20dYrLC6OC33cnOTSutHRJWkp5vu2ajOGRvNA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU
	QOM'ification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On 26 March 2012 18:28, Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> +static void arm_cpu_reset(CPUState *c)
> +{
> + =C2=A0 =C2=A0ARMCPU *cpu =3D ARM_CPU(c);
> + =C2=A0 =C2=A0ARMCPUClass *class =3D ARM_CPU_GET_CLASS(cpu);
> +
> + =C2=A0 =C2=A0class->parent_reset(c);

I thought we were avoiding 'class' in favour of 'klass'?

> +static const TypeInfo arm_cpu_type_info =3D {
> + =C2=A0 =C2=A0.name =3D TYPE_ARM_CPU,
> + =C2=A0 =C2=A0.parent =3D TYPE_CPU,
> + =C2=A0 =C2=A0.instance_size =3D sizeof(ARMCPU),
> + =C2=A0 =C2=A0.abstract =3D false, /* TODO Reconsider once cp15 reworked=
. */

As it happens I'm planning to create the per-implementation
subclasses first and do the cp15 rework second.

-- PMM