From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B5EC35E03 for ; Tue, 25 Feb 2020 14:13:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28A5D2176D for ; Tue, 25 Feb 2020 14:13:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mjXAp/jR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28A5D2176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6axr-0006MY-9d for qemu-devel@archiver.kernel.org; Tue, 25 Feb 2020 09:13:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39740) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6aIa-0002OV-Qd for qemu-devel@nongnu.org; Tue, 25 Feb 2020 08:31:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6aIW-0000ol-NU for qemu-devel@nongnu.org; Tue, 25 Feb 2020 08:30:56 -0500 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:37704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6aIW-0000oR-HQ for qemu-devel@nongnu.org; Tue, 25 Feb 2020 08:30:52 -0500 Received: by mail-ot1-x341.google.com with SMTP id b3so12044679otp.4 for ; Tue, 25 Feb 2020 05:30:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W00TYEGv3o3wTI6WlTZXldTZ7RdbF0jWLul8rx17LRo=; b=mjXAp/jRux95OCK3rTAr1wBK2KraYyMtCymOO8VWHnyzA8s+tfJ/SBHDxKs8QCymsW 54KTR6+kWPJQx/VV729vpEpw8zK+5g7iPFL7pNGw0DmrOPsTYi8iSsMzU44NOGnd9dYR xOUMW2NNygTPPsRyB1s1kleDoQoxH5xiG2RGXrvmpkECkztL7W6S8kRRlNx64+2U7wUb h5gCuwLPHMdM7eev5NZOkWqotBF5sEu9KKxWoaS0mv1Xm6AWkQMoEMVQSbqrRHPDS1Mt vay2/UUc3uBX3wBw7OAEcjehZxLXG+nKiT3CSZNywTlpTaqDa+y8FAVaYq8Hl/qrU2Mz K4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W00TYEGv3o3wTI6WlTZXldTZ7RdbF0jWLul8rx17LRo=; b=UbEbSlyYITIEgHWiVaTmYKy9f4t77UlfqFMsBohDHw38tp7m/QIe0g/EYmip1lJXV2 lLez/CZYW52oJ9yTU+c4gAXUT7ONOzuImTsPULjKPfn8gmGFFTYMeHJ3pgD4mSC936mF 7Vp9jmODG3xgMnM1AKclruCow046vwQ/DYhsKcXVsta+6otFhliAeKW5Q+9tG5cl97i1 Ha1fLeOiFPe9krUfyvfFfGRrbaw2P/Vihvw0tdc+9GsWkI2CSEYof7MacGagnqdZlErV xB9+nhEk57m8TTBcZ4MMxdDEmG9tVW1GjV3RSh/W+HRnmd8yrcN4TN8PLFON7tVaLkr+ yUWg== X-Gm-Message-State: APjAAAWIma8weBCMcThE5OdNyafdlABv4R4rR4x+zE9sEBmpFrM0vUcW ps+C6LpvnFNXrHBQ0NI6Vaz8/RcBeLPL3iB8PPY/UQ== X-Google-Smtp-Source: APXvYqwYFu7QWTSW+/Kn6KA211hYsolFNVV3Y6lEjUmRuYvMw+cVUmAiJ7arecPsT9uZJrntvPoIzJmH+1Ecoa+J3vY= X-Received: by 2002:a05:6830:1184:: with SMTP id u4mr42540624otq.221.1582637451828; Tue, 25 Feb 2020 05:30:51 -0800 (PST) MIME-Version: 1.0 References: <20200224222232.13807-1-richard.henderson@linaro.org> <20200224222232.13807-14-richard.henderson@linaro.org> In-Reply-To: <20200224222232.13807-14-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 25 Feb 2020 13:30:40 +0000 Message-ID: Subject: Re: [PATCH v2 13/17] linux-user/arm: Replace ARM_FEATURE_VFP* tests for HWCAP To: Richard Henderson Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 24 Feb 2020 at 22:22, Richard Henderson wrote: > > Use isar feature tests instead of feature bit tests. > > Although none of QEMUs current cpus have VFPv3 without D32, > replace the large comment explaining why with one line that > sets ARM_HWCAP_ARM_VFPv3D16 under the correct conditions. > Mirror the test sequence used in the linux kernel. > > Signed-off-by: Richard Henderson > --- > v2: Use isar_feature_aa32_vfp. > --- Reviewed-by: Peter Maydell thanks -- PMM