From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Michael Young <m.a.young@durham.ac.uk>,
qemu-devel@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH] fix qemu build with xen-4.18.0
Date: Fri, 8 Dec 2023 10:59:03 +0000 [thread overview]
Message-ID: <CAFEAcA8HXWEPbx2fKEg_kscdEnNpGCJVO9jqgD1YDpULYp_yDw@mail.gmail.com> (raw)
In-Reply-To: <ZXLg_YCHM-P6drQV@redhat.com>
On Fri, 8 Dec 2023 at 09:25, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> CC'ing the Xen folks
>
> On Thu, Dec 07, 2023 at 11:12:48PM +0000, Michael Young wrote:
> > diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h
> > index 6f09c48823..04b1ef4d34 100644
> > --- a/include/hw/xen/xen_native.h
> > +++ b/include/hw/xen/xen_native.h
> > @@ -532,7 +532,7 @@ static inline int xendevicemodel_set_irq_level(xendevicemodel_handle *dmod,
> > }
> > #endif
> >
> > -#if CONFIG_XEN_CTRL_INTERFACE_VERSION <= 41700
> > +#if CONFIG_XEN_CTRL_INTERFACE_VERSION >= 41700
>
> This change is not correct
>
> We can see the upstream change was introduced in 4.17:
>
> $ git describe 2128143c114
> 4.16.0-rc4-967-g2128143c11
>
> IOW, if we have 4.17 or newer these constants already
> exist. If we have 4.16 or older, then we need to define
> them to provide back compat.
Wouldn't that suggest we want "< 41700" ? Or did 4.17 have
some issue that means we need the back-compat there too?
thanks
-- PMM
next prev parent reply other threads:[~2023-12-08 10:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 23:12 [PATCH] fix qemu build with xen-4.18.0 Michael Young
2023-12-08 8:47 ` Richard W.M. Jones
2023-12-08 9:59 ` Richard W.M. Jones
2023-12-08 10:00 ` Richard W.M. Jones
2023-12-08 9:25 ` Daniel P. Berrangé
2023-12-08 10:59 ` Peter Maydell [this message]
2023-12-08 11:34 ` Daniel P. Berrangé
2023-12-08 22:49 ` Stefano Stabellini
2023-12-12 14:19 ` Anthony PERARD
2023-12-12 14:36 ` Peter Maydell
2023-12-12 15:35 ` Volodymyr Babchuk
2023-12-12 15:47 ` Stefan Hajnoczi
2023-12-12 16:02 ` Volodymyr Babchuk
2023-12-12 16:29 ` Stefan Hajnoczi
2023-12-12 16:00 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8HXWEPbx2fKEg_kscdEnNpGCJVO9jqgD1YDpULYp_yDw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=m.a.young@durham.ac.uk \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).