From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
zhangfei.gao@foxmail.com, QEMU Developers <qemu-devel@nongnu.org>,
Peter Xu <peterx@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Eric Auger <eric.auger.pro@gmail.com>
Subject: Re: [PATCH v3 09/11] hw/arm/smmuv3: Let AIDR advertise SMMUv3.0 support
Date: Fri, 10 Jul 2020 10:10:35 +0100 [thread overview]
Message-ID: <CAFEAcA8H_wOCDdoSeTALXV_QArm6EjCdHiUZYW3ezTW287V28Q@mail.gmail.com> (raw)
In-Reply-To: <20200708141856.15776-10-eric.auger@redhat.com>
On Wed, 8 Jul 2020 at 15:20, Eric Auger <eric.auger@redhat.com> wrote:
>
> Add the support for AIDR register. It currently advertises
> SMMU V3.0 spec.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>
> ---
> ---
> hw/arm/smmuv3-internal.h | 1 +
> include/hw/arm/smmuv3.h | 1 +
> hw/arm/smmuv3.c | 3 +++
> 3 files changed, 5 insertions(+)
>
> diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h
> index ef093eaff5..6296235020 100644
> --- a/hw/arm/smmuv3-internal.h
> +++ b/hw/arm/smmuv3-internal.h
> @@ -64,6 +64,7 @@ REG32(IDR5, 0x14)
> #define SMMU_IDR5_OAS 4
>
> REG32(IIDR, 0x18)
> +REG32(AIDR, 0x1C)
Rest of file uses lowercase letters for hex values, so "0x1c".
> REG32(CR0, 0x20)
> FIELD(CR0, SMMU_ENABLE, 0, 1)
> FIELD(CR0, EVENTQEN, 2, 1)
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2020-07-10 9:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 14:18 [PATCH v3 00/11] SMMUv3.2 Range-based TLB Invalidation Support Eric Auger
2020-07-08 14:18 ` [PATCH v3 01/11] hw/arm/smmu-common: Factorize some code in smmu_ptw_64() Eric Auger
2020-07-08 14:18 ` [PATCH v3 02/11] hw/arm/smmu-common: Add IOTLB helpers Eric Auger
2020-07-08 14:18 ` [PATCH v3 03/11] hw/arm/smmu: Introduce smmu_get_iotlb_key() Eric Auger
2020-07-08 14:18 ` [PATCH v3 04/11] hw/arm/smmu: Introduce SMMUTLBEntry for PTW and IOTLB value Eric Auger
2020-07-08 14:18 ` [PATCH v3 05/11] hw/arm/smmu-common: Manage IOTLB block entries Eric Auger
2020-07-10 9:00 ` Peter Maydell
2020-07-10 9:02 ` Peter Maydell
2020-07-08 14:18 ` [PATCH v3 06/11] hw/arm/smmuv3: Introduce smmuv3_s1_range_inval() helper Eric Auger
2020-07-08 14:18 ` [PATCH v3 07/11] hw/arm/smmuv3: Get prepared for range invalidation Eric Auger
2020-07-10 9:06 ` Peter Maydell
2020-07-08 14:18 ` [PATCH v3 08/11] hw/arm/smmuv3: Fix IIDR offset Eric Auger
2020-07-10 9:08 ` Peter Maydell
2020-07-08 14:18 ` [PATCH v3 09/11] hw/arm/smmuv3: Let AIDR advertise SMMUv3.0 support Eric Auger
2020-07-10 9:10 ` Peter Maydell [this message]
2020-07-08 14:18 ` [PATCH v3 10/11] hw/arm/smmuv3: Support HAD and advertise SMMUv3.1 support Eric Auger
2020-07-10 9:31 ` Peter Maydell
2020-07-08 14:18 ` [PATCH v3 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation Eric Auger
2020-07-10 9:47 ` Peter Maydell
2020-07-10 10:05 ` Auger Eric
2020-07-10 10:39 ` Peter Maydell
2020-07-28 15:09 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8H_wOCDdoSeTALXV_QArm6EjCdHiUZYW3ezTW287V28Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).