* [Qemu-devel] [PATCH] hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range
@ 2016-05-21 18:43 Ard Biesheuvel
2016-05-24 8:18 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2016-05-21 18:43 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, p.fedin, Ard Biesheuvel
Set the MMIO range limit field to 'base + size - 1' as required.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
hw/arm/virt-acpi-build.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f51fe396ce9c..60a70370dd96 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -230,7 +230,8 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
aml_append(rbuf,
aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,
- base_mmio_high, base_mmio_high, 0x0000,
+ base_mmio_high,
+ base_mmio_high + size_mmio_high - 1, 0x0000,
size_mmio_high));
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range
2016-05-21 18:43 [Qemu-devel] [PATCH] hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range Ard Biesheuvel
@ 2016-05-24 8:18 ` Laszlo Ersek
2016-05-24 9:01 ` Shannon Zhao
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2016-05-24 8:18 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: qemu-devel, peter.maydell, p.fedin, Shannon Zhao
On 05/21/16 20:43, Ard Biesheuvel wrote:
> Set the MMIO range limit field to 'base + size - 1' as required.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> hw/arm/virt-acpi-build.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index f51fe396ce9c..60a70370dd96 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -230,7 +230,8 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
> aml_append(rbuf,
> aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
> AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,
> - base_mmio_high, base_mmio_high, 0x0000,
> + base_mmio_high,
> + base_mmio_high + size_mmio_high - 1, 0x0000,
> size_mmio_high));
> }
>
>
$ scripts/get_maintainer.pl -f hw/arm/virt-acpi-build.c
"Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS)
Igor Mammedov <imammedo@redhat.com> (supporter:ACPI/SMBIOS)
Shannon Zhao <zhaoshenglong@huawei.com> (maintainer:ARM ACPI Subsystem)
Peter Maydell <peter.maydell@linaro.org> (maintainer:ARM)
qemu-arm@nongnu.org (open list:ARM ACPI Subsystem)
qemu-devel@nongnu.org (open list:All patches CC here)
For this patch specifically, I'm CC'ing Shannon.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range
2016-05-24 8:18 ` Laszlo Ersek
@ 2016-05-24 9:01 ` Shannon Zhao
2016-05-24 15:51 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Shannon Zhao @ 2016-05-24 9:01 UTC (permalink / raw)
To: Laszlo Ersek, Ard Biesheuvel; +Cc: qemu-devel, peter.maydell, p.fedin
On 2016/5/24 16:18, Laszlo Ersek wrote:
> On 05/21/16 20:43, Ard Biesheuvel wrote:
>> Set the MMIO range limit field to 'base + size - 1' as required.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> hw/arm/virt-acpi-build.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
>> index f51fe396ce9c..60a70370dd96 100644
>> --- a/hw/arm/virt-acpi-build.c
>> +++ b/hw/arm/virt-acpi-build.c
>> @@ -230,7 +230,8 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
>> aml_append(rbuf,
>> aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
>> AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,
>> - base_mmio_high, base_mmio_high, 0x0000,
>> + base_mmio_high,
>> + base_mmio_high + size_mmio_high - 1, 0x0000,
>> size_mmio_high));
>> }
>>
>>
>
> $ scripts/get_maintainer.pl -f hw/arm/virt-acpi-build.c
>
> "Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS)
> Igor Mammedov <imammedo@redhat.com> (supporter:ACPI/SMBIOS)
> Shannon Zhao <zhaoshenglong@huawei.com> (maintainer:ARM ACPI Subsystem)
> Peter Maydell <peter.maydell@linaro.org> (maintainer:ARM)
> qemu-arm@nongnu.org (open list:ARM ACPI Subsystem)
> qemu-devel@nongnu.org (open list:All patches CC here)
>
> For this patch specifically, I'm CC'ing Shannon.
>
Thanks, Laszlo :)
--
Shannon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range
2016-05-24 9:01 ` Shannon Zhao
@ 2016-05-24 15:51 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-05-24 15:51 UTC (permalink / raw)
To: Shannon Zhao; +Cc: Laszlo Ersek, Ard Biesheuvel, QEMU Developers, Pavel Fedin
On 24 May 2016 at 10:01, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>
>
> On 2016/5/24 16:18, Laszlo Ersek wrote:
>> On 05/21/16 20:43, Ard Biesheuvel wrote:
>>> Set the MMIO range limit field to 'base + size - 1' as required.
>>>
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-24 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-21 18:43 [Qemu-devel] [PATCH] hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range Ard Biesheuvel
2016-05-24 8:18 ` Laszlo Ersek
2016-05-24 9:01 ` Shannon Zhao
2016-05-24 15:51 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).