qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: peter.crosthwaite@xilinx.com, aliguori@us.ibm.com,
	sw@weilnetz.de, qemu-devel@nongnu.org, blauwirbel@gmail.com,
	paul@codesourcery.com, stefanha@redhat.com, pbonzini@redhat.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data
Date: Fri, 14 Jun 2013 12:49:52 +0100	[thread overview]
Message-ID: <CAFEAcA8J3c6MtjMsMpN77RTAnHmte9tSb54yCPQcfzt5m=zceg@mail.gmail.com> (raw)
In-Reply-To: <1368202225-45798-3-git-send-email-i.mitsyanko@gmail.com>

On 10 May 2013 17:10, Igor Mitsyanko <i.mitsyanko@gmail.com> wrote:
> Initialize it appropriately when various commands are processed.

"tracking", but the commit message doesn't match the
patch contents anyway -- should this patch have more
content from later patches, or be squashed into one of
them?

>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
> ---
>  hw/sd/sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 1dd1331..775a55c 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -116,6 +116,7 @@ struct SDState {
>      QEMUIOVector qiov;
>      struct iovec iov;
>      BlockDriverAIOCB *aiocb;
> +    uint32_t transf_cnt;

How does this work for migration -- are we guaranteed that
all outstanding AIO requests complete before we try to
migrate?

>  };
>
>  static void sd_set_mode(SDState *sd)
> --
> 1.8.1.4
>


thanks
-- PMM

  reply	other threads:[~2013-06-14 11:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 16:10 [Qemu-devel] [RFC 0/7] Convert SD card model to AIO Igor Mitsyanko
2013-05-10 16:10 ` [Qemu-devel] [RFC 1/7] sd.c: introduce AIO related members in SD state Igor Mitsyanko
2013-05-10 16:10 ` [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data Igor Mitsyanko
2013-06-14 11:49   ` Peter Maydell [this message]
2013-06-17 12:30     ` Stefan Hajnoczi
2013-06-17 14:03       ` Paolo Bonzini
2013-05-10 16:10 ` [Qemu-devel] [RFC 3/7] sd.c: introduce "start bit" and "busy deasserted" callbacks Igor Mitsyanko
2013-06-14 11:51   ` Peter Maydell
2013-05-10 16:10 ` [Qemu-devel] [RFC 4/7] sd.c: use callbacks as a flag to use async IO Igor Mitsyanko
2013-05-10 16:10 ` [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation Igor Mitsyanko
2013-05-13 12:10   ` Stefan Hajnoczi
2013-05-10 16:10 ` [Qemu-devel] [RFC 6/7] sd.c: introduce async write interface Igor Mitsyanko
2013-06-14 12:09   ` Peter Maydell
2013-05-10 16:10 ` [Qemu-devel] [RFC 7/7] pl181.c: convert to async IO SD card interface Igor Mitsyanko
2013-06-14 12:05   ` Peter Maydell
2013-05-13 12:13 ` [Qemu-devel] [RFC 0/7] Convert SD card model to AIO Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8J3c6MtjMsMpN77RTAnHmte9tSb54yCPQcfzt5m=zceg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=i.mitsyanko@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).