From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxFHl-0008Dt-Ul for qemu-devel@nongnu.org; Tue, 26 May 2015 09:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxFHi-0002sc-P8 for qemu-devel@nongnu.org; Tue, 26 May 2015 09:52:49 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:33761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxFHi-0002sO-Kg for qemu-devel@nongnu.org; Tue, 26 May 2015 09:52:46 -0400 Received: by igbpi8 with SMTP id pi8so59750554igb.0 for ; Tue, 26 May 2015 06:52:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5564702F.2030308@linaro.org> References: <1432464666-4825-1-git-send-email-christoffer.dall@linaro.org> <1432464666-4825-5-git-send-email-christoffer.dall@linaro.org> <55646D0F.9040801@linaro.org> <5564702F.2030308@linaro.org> From: Peter Maydell Date: Tue, 26 May 2015 14:52:25 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger Cc: QEMU Developers , Christoffer Dall , "kvmarm@lists.cs.columbia.edu" On 26 May 2015 at 14:07, Eric Auger wrote: > On 05/26/2015 02:55 PM, Peter Maydell wrote: >> On 26 May 2015 at 13:54, Eric Auger wrote: >>> Reviewed-by: Eric Auger >>> >>> The only question I have is related to mid-term virt strategy about >>> GICv3 integration. Are we going to reuse that memory map for the machine >>> instantiating the GICv3? If yes, shouldn't we put the GICv2M somewhere >>> else to leave space for GICv3 redistributors, assuming we reuse the >>> shared distributor region. I understood the memory map is difficult to >>> change once applied once. >> >> I wouldn't expect that you'd have a GICv2M at all in a >> system with a GICv3 in it, would you? > > no indeed. but we currently use a single static a15memmap memory map in > virt. This one is currently planned to be reused for machines > instantiating GICv3 so we start seeing things like > VIRT_GIC_CPU = VIRT_GIC_REDIST. I fear this is going to become messy. I think the answer is not to reuse constant names like that. The v3 redistributor is not a v2 CPU interface, just as a UART is not an RTC. -- PMM