From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: "Patch Tracking" <patches@linaro.org>,
"Alexander Graf" <agraf@suse.de>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH for-2.0] hw/pci-host/prep: Don't reverse IO accesses on bigendian hosts
Date: Tue, 8 Apr 2014 18:53:42 +0100 [thread overview]
Message-ID: <CAFEAcA8JDD=DZ1Bi1aa6t3ddzTsnaJ99LNichO-kvH8GU3SBhw@mail.gmail.com> (raw)
In-Reply-To: <534430BA.70801@twiddle.net>
On 8 April 2014 18:24, Richard Henderson <rth@twiddle.net> wrote:
> On 04/08/2014 08:51 AM, Peter Maydell wrote:
>> The raven_io_read() and raven_io_write() functions pass and
>> return values in little-endian format (since the IO op struct
>> is marked DEVICE_LITTLE_ENDIAN); however they were storing the
>> values in the buffer to pass to address_space_read/write()
>> in host-endian order, which meant that on big-endian hosts
>> the values were inadvertently reversed. Use the *_le_p()
>> accessors instead so that we are consistent regardless of
>> host endianness.
> Reviewed-by: Richard Henderson <rth@twiddle.net>
Thanks; applied to master.
-- PMM
prev parent reply other threads:[~2014-04-08 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 15:51 [Qemu-devel] [PATCH for-2.0] hw/pci-host/prep: Don't reverse IO accesses on bigendian hosts Peter Maydell
2014-04-08 17:08 ` Peter Maydell
2014-04-08 17:24 ` Richard Henderson
2014-04-08 17:53 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8JDD=DZ1Bi1aa6t3ddzTsnaJ99LNichO-kvH8GU3SBhw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=hpoussin@reactos.org \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).