From: Peter Maydell <peter.maydell@linaro.org>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair23@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] Makefile: Capstone: Add support for cross compile ranlib
Date: Thu, 9 Nov 2017 11:09:32 +0000 [thread overview]
Message-ID: <CAFEAcA8JS+51wyEYKsaestz-ADijZqGpv4tCv1wvfpwfXBB6MA@mail.gmail.com> (raw)
In-Reply-To: <14c2a46a082a9e34d6cbd3aba0fb47e353850d0d.1510153659.git.alistair.francis@xilinx.com>
On 8 November 2017 at 15:10, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> When cross compiling QEMU for Windows we need to specify the cross
> version of ranlib to avoid build errors when building capstone. This
> patch ensures we use the same cross prefix on ranlib as other toolchain
> components.
>
> This patch fixes this build error when building on RHEL (or Fedora) with
> MinGW:
> /scratch/jenkins_tmp/workspace/QEMU-BuildAll/label/ssw_rhel7/target/windows/build-windows/capstone/capstone.lib:
> error adding symbols: Archive has no index; run ranlib to add one
> collect2: error: ld returned 1 exit status
> make: *** [qemu-io.exe] Error 1
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Philippe Mathieu-Daud <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daud <f4bug@amsat.org>
Something in your patch handling workflow seems to be
breaking non-ASCII characters, and it has dropped the
last character in Philippe's surname. It would be good
if you could look into fixing this -- we have quite a
few contributors whose names are not representable
purely in ASCII.
thanks
-- PMM
next prev parent reply other threads:[~2017-11-09 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 15:10 [Qemu-devel] [PATCH v2 1/1] Makefile: Capstone: Add support for cross compile ranlib Alistair Francis
2017-11-09 11:09 ` Peter Maydell [this message]
2017-11-10 1:27 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8JS+51wyEYKsaestz-ADijZqGpv4tCv1wvfpwfXBB6MA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).