From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41396)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YvKXW-0005H7-0e
	for qemu-devel@nongnu.org; Thu, 21 May 2015 03:05:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YvKXS-0003wU-1Q
	for qemu-devel@nongnu.org; Thu, 21 May 2015 03:05:09 -0400
Received: from mail-ie0-f177.google.com ([209.85.223.177]:33011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YvKXR-0003uZ-NT
	for qemu-devel@nongnu.org; Thu, 21 May 2015 03:05:05 -0400
Received: by iebgx4 with SMTP id gx4so1835205ieb.0
	for <qemu-devel@nongnu.org>; Thu, 21 May 2015 00:05:05 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20150521054712.GU30952@toto>
References: <1432060414-5195-1-git-send-email-peter.maydell@linaro.org>
	<1432060414-5195-9-git-send-email-peter.maydell@linaro.org>
	<20150521054712.GU30952@toto>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 21 May 2015 08:04:44 +0100
Message-ID: <CAFEAcA8JVnMr4Z5C-8S=J2RqP=PizdED=YrkEEHDZCH1RACxWw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 08/14] target-arm: Allow cp access
 functions to indicate traps to EL2 or EL3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Cc: Alexander Graf <agraf@suse.de>, Sergey Fedorov <serge.fdrv@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 21 May 2015 at 06:47, Edgar E. Iglesias <edgar.iglesias@xilinx.com> wrote:
> On Tue, May 19, 2015 at 07:33:28PM +0100, Peter Maydell wrote:
>>      case CP_ACCESS_TRAP_UNCATEGORIZED:
>>          syndrome = syn_uncategorized();
>
> It looks like you need a:
> target_el = exception_target_el(env);
>
> here, no?

Oops, yes.

-- PMM