From: Peter Maydell <peter.maydell@linaro.org>
To: Evgeny Voevodin <e.voevodin@samsung.com>
Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com,
jehyung.lee@samsung.com, qemu-devel@nongnu.org,
d.solodkiy@samsung.com
Subject: Re: [Qemu-devel] [PATCH v8 1/8] ARM: exynos4210: IRQ subsystem support.
Date: Thu, 19 Jan 2012 12:05:50 +0000 [thread overview]
Message-ID: <CAFEAcA8Jid2AMp4m0A8CPeDi6bEWK6-e89ebwHSm4my1D5LJgw@mail.gmail.com> (raw)
In-Reply-To: <1326961896-25420-2-git-send-email-e.voevodin@samsung.com>
On 19 January 2012 08:31, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> +#define GIC_NIRQ 160
> +#include "arm_gic.c"
NB that when my current outstanding arm-devs pullreq lands
you'll need to update this to handle the changes in
http://patchwork.ozlabs.org/patch/136609/
This shouldn't be too hard -- you can use the changes that
patch makes to eg realview_gic.c as a guide. Basically the number
of IRQs is now a parameter to gic_init() rather than a #define.
(If it's possible for different Exynos4210 configurations to
have different numbers of IRQs then you can make num-irq
a qdev property as is done with a9mpcore.c, but I'm guessing
that 160 is a fixed value for the SoC and need not be configurable.)
Patch looks OK otherwise I think.
-- PMM
next prev parent reply other threads:[~2012-01-19 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 8:31 [Qemu-devel] [PATCH v8 0/8] ARM: Samsung Exynos4210-based boards support Evgeny Voevodin
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 1/8] ARM: exynos4210: IRQ subsystem support Evgeny Voevodin
2012-01-19 12:05 ` Peter Maydell [this message]
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 2/8] ARM: Samsung exynos4210-based boards emulation Evgeny Voevodin
2012-01-19 12:19 ` Peter Maydell
2012-01-19 13:15 ` Evgeny Voevodin
2012-01-19 13:26 ` Peter Maydell
2012-01-19 13:17 ` Andreas Färber
2012-01-20 7:18 ` Kyungmin Park
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 3/8] ARM: exynos4210: UART support Evgeny Voevodin
2012-01-19 12:35 ` Peter Maydell
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 4/8] ARM: exynos4210: PWM support Evgeny Voevodin
2012-01-19 12:40 ` Peter Maydell
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 5/8] ARM: exynos4210: MCT support Evgeny Voevodin
2012-01-19 12:46 ` Peter Maydell
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 6/8] hw/lan9118: Add basic 16-bit mode support Evgeny Voevodin
2012-01-19 12:41 ` Peter Maydell
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 7/8] hw/exynos4210.c: Add LAN support for SMDKC210 Evgeny Voevodin
2012-01-19 8:31 ` [Qemu-devel] [PATCH v8 8/8] Exynos4210: added display controller implementation Evgeny Voevodin
2012-01-19 12:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Jid2AMp4m0A8CPeDi6bEWK6-e89ebwHSm4my1D5LJgw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=jehyung.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).