From: Peter Maydell <peter.maydell@linaro.org>
To: Gonglei <arei.gonglei@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] virtio: link the rng backend through an alias property
Date: Thu, 30 Oct 2014 13:34:47 +0000 [thread overview]
Message-ID: <CAFEAcA8Ju+inYARVDYhHYHFP_S7_0om6A3qqgPemU7PsuSFGTA@mail.gmail.com> (raw)
In-Reply-To: <5450C19C.4090909@huawei.com>
On 29 October 2014 10:29, Gonglei <arei.gonglei@huawei.com> wrote:
> On 2014/10/29 18:17, Paolo Bonzini wrote:
>
>> The virtio-rng backend is currently linked twice, once in the proxy
>> device (e.g. virtio-rng-pci) and once in virtio-rng-device. This causes
>> a double unref of the backend when the parent device is unplugged.
>>
>> To fix this, make the proxy device use an alias, similar to what is
>> already being done for the iothread link.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> ---
>> v1->v2: also change s390-virtio-bus.c (Gonglei)
>> ---
>> hw/s390x/s390-virtio-bus.c | 6 ++----
>> hw/s390x/virtio-ccw.c | 6 ++----
>> hw/virtio/virtio-pci.c | 7 ++-----
>> 3 files changed, 6 insertions(+), 13 deletions(-)
>
> Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Applied to master, thanks.
-- PMM
prev parent reply other threads:[~2014-10-31 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 10:17 [Qemu-devel] [PATCH v2] virtio: link the rng backend through an alias property Paolo Bonzini
2014-10-29 10:29 ` Gonglei
2014-10-30 13:34 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Ju+inYARVDYhHYHFP_S7_0om6A3qqgPemU7PsuSFGTA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=arei.gonglei@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).