From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkEPt-0001yY-3v for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:48:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xjpsb-0005ds-NF for qemu-devel@nongnu.org; Thu, 30 Oct 2014 09:35:14 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:48987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjpsb-0005dO-HQ for qemu-devel@nongnu.org; Thu, 30 Oct 2014 09:35:09 -0400 Received: by mail-la0-f47.google.com with SMTP id gd6so3172370lab.6 for ; Thu, 30 Oct 2014 06:35:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5450C19C.4090909@huawei.com> References: <1414577839-18695-1-git-send-email-pbonzini@redhat.com> <5450C19C.4090909@huawei.com> From: Peter Maydell Date: Thu, 30 Oct 2014 13:34:47 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] virtio: link the rng backend through an alias property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: Paolo Bonzini , QEMU Developers On 29 October 2014 10:29, Gonglei wrote: > On 2014/10/29 18:17, Paolo Bonzini wrote: > >> The virtio-rng backend is currently linked twice, once in the proxy >> device (e.g. virtio-rng-pci) and once in virtio-rng-device. This causes >> a double unref of the backend when the parent device is unplugged. >> >> To fix this, make the proxy device use an alias, similar to what is >> already being done for the iothread link. >> >> Signed-off-by: Paolo Bonzini >> >> --- >> v1->v2: also change s390-virtio-bus.c (Gonglei) >> --- >> hw/s390x/s390-virtio-bus.c | 6 ++---- >> hw/s390x/virtio-ccw.c | 6 ++---- >> hw/virtio/virtio-pci.c | 7 ++----- >> 3 files changed, 6 insertions(+), 13 deletions(-) > > Reviewed-by: Gonglei Applied to master, thanks. -- PMM