qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Greg Kurz <groug@kaod.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests-aio-multithread: use atomic_read properly
Date: Mon, 27 Feb 2017 13:39:18 +0000	[thread overview]
Message-ID: <CAFEAcA8JzkpOvhLaoMX21gqb+0t2Dqc+a2F-Ens-GyEEtTC_4Q@mail.gmail.com> (raw)
In-Reply-To: <20170227130120.6ec54cc2@bahia.lan>

On 27 February 2017 at 12:01, Greg Kurz <groug@kaod.org> wrote:
> On Mon, 27 Feb 2017 12:17:26 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>> nodes[id].next is written by other threads.  If atomic_read is not used
>> (matching atomic_set in mcs_mutex_lock!) the compiler can optimize the
>> whole "if" away!
>>
>> Reported-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>
> Cool ! I can use travis again :)
>
> Tested-by: Greg Kurz <groug@kaod.org>
>

Thanks; applied to master as a build fix.

-- PMM

  reply	other threads:[~2017-02-27 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 11:17 [Qemu-devel] [PATCH] tests-aio-multithread: use atomic_read properly Paolo Bonzini
2017-02-27 12:01 ` Greg Kurz
2017-02-27 13:39   ` Peter Maydell [this message]
2017-02-27 14:01 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8JzkpOvhLaoMX21gqb+0t2Dqc+a2F-Ens-GyEEtTC_4Q@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=groug@kaod.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).