From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXT1n-00042h-Lo for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:45:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXT1i-0002Bc-JI for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:45:31 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:35316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXT1i-0002AS-EC for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:45:26 -0400 Received: by mail-pd0-f177.google.com with SMTP id v10so10701559pde.8 for ; Fri, 26 Sep 2014 03:45:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1410626734-3804-1-git-send-email-rth@twiddle.net> References: <1410626734-3804-1-git-send-email-rth@twiddle.net> From: Peter Maydell Date: Fri, 26 Sep 2014 11:45:00 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 00/23] qom hooks to clean up cpu_exec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: QEMU Developers , Anthony Liguori , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 13 September 2014 17:45, Richard Henderson wrote: > Prompted by trying to review Martin's ARM exception vs gdb > problems, let's clean up cpu_exec so that it's almost readable. > > After the 23 patches, there's one (interesting) ifdef left. > That is, i386 redefining CPU_INTERRUPT_RESET as CPU_INTERRUPT_INIT > for its own purposes. I'm not sure why all that couldn't be done > under whatever hooks cpu_reset allows. Failing that, we might be > able to redefine C_I_I as a new CPU_INTERRUPT_TGT_INT_3 bit. > > I've done some smoke tests on i386, arm, xtensa, because I had > images handy. But I've not done anything but compile the rest. > > Comments appreciated. Applied to master, thanks. -- PMM