From: Peter Maydell <peter.maydell@linaro.org>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device
Date: Fri, 29 Nov 2013 11:10:04 +0000 [thread overview]
Message-ID: <CAFEAcA8K_wSyU8=Va7wA4kN+Tm22E2Ak6jZPzAXRuxL8ML13XQ@mail.gmail.com> (raw)
In-Reply-To: <1385540994-27940-1-git-send-email-lig.fnst@cn.fujitsu.com>
On 27 November 2013 08:29, liguang <lig.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> default-configs/arm-softmmu.mak | 2 +
> hw/timer/Makefile.objs | 1 +
> hw/timer/sunxi-pit.c | 254 +++++++++++++++++++++++++++++++++++++++
> include/hw/timer/sunxi-pit.h | 56 +++++++++
> 4 files changed, 313 insertions(+), 0 deletions(-)
> create mode 100644 hw/timer/sunxi-pit.c
> create mode 100644 include/hw/timer/sunxi-pit.h
Please use scripts/checkpatch.pl on your patches:
it finds a lot of minor formatting errors which you
should fix. (It is not always correct but it will
spot things like missing spaces, use of hard tabs,
missing braces and so on.)
thanks
-- PMM
prev parent reply other threads:[~2013-11-29 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 8:29 [Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device liguang
2013-11-27 13:35 ` Peter Crosthwaite
2013-11-29 0:51 ` Peter Crosthwaite
2013-11-29 7:55 ` Li Guang
2013-11-29 11:10 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8K_wSyU8=Va7wA4kN+Tm22E2Ak6jZPzAXRuxL8ML13XQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=lig.fnst@cn.fujitsu.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).