From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmLxv-0007kh-Jy for qemu-devel@nongnu.org; Fri, 29 Nov 2013 06:10:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmLxq-0006Ez-M6 for qemu-devel@nongnu.org; Fri, 29 Nov 2013 06:10:31 -0500 Received: from mail-pd0-f182.google.com ([209.85.192.182]:35406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmLxq-0006Et-Gs for qemu-devel@nongnu.org; Fri, 29 Nov 2013 06:10:26 -0500 Received: by mail-pd0-f182.google.com with SMTP id v10so13580534pde.41 for ; Fri, 29 Nov 2013 03:10:25 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1385540994-27940-1-git-send-email-lig.fnst@cn.fujitsu.com> References: <1385540994-27940-1-git-send-email-lig.fnst@cn.fujitsu.com> From: Peter Maydell Date: Fri, 29 Nov 2013 11:10:04 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: Peter Crosthwaite , QEMU Developers On 27 November 2013 08:29, liguang wrote: > Signed-off-by: liguang > --- > default-configs/arm-softmmu.mak | 2 + > hw/timer/Makefile.objs | 1 + > hw/timer/sunxi-pit.c | 254 +++++++++++++++++++++++++++++++++++++++ > include/hw/timer/sunxi-pit.h | 56 +++++++++ > 4 files changed, 313 insertions(+), 0 deletions(-) > create mode 100644 hw/timer/sunxi-pit.c > create mode 100644 include/hw/timer/sunxi-pit.h Please use scripts/checkpatch.pl on your patches: it finds a lot of minor formatting errors which you should fix. (It is not always correct but it will spot things like missing spaces, use of hard tabs, missing braces and so on.) thanks -- PMM