From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkeNE-0001l5-SU for qemu-devel@nongnu.org; Tue, 10 Jan 2012 11:16:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkeN4-00053G-7j for qemu-devel@nongnu.org; Tue, 10 Jan 2012 11:16:32 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:46592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkeN3-000537-Tq for qemu-devel@nongnu.org; Tue, 10 Jan 2012 11:16:22 -0500 Received: by qcsd15 with SMTP id d15so2963710qcs.4 for ; Tue, 10 Jan 2012 08:16:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1324640414-16000-9-git-send-email-e.voevodin@samsung.com> References: <1324640414-16000-1-git-send-email-e.voevodin@samsung.com> <1324640414-16000-9-git-send-email-e.voevodin@samsung.com> Date: Tue, 10 Jan 2012 16:16:21 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 08/11] hw/exynos4210.c: Boot secondary CPU. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Evgeny Voevodin Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com On 23 December 2011 11:40, Evgeny Voevodin wrote: > + =C2=A0 =C2=A0/* > + =C2=A0 =C2=A0 * Hack: Map SECOND_CPU_BOOTREG, because it is in PMU USER= 5 register. > + =C2=A0 =C2=A0 */ Shouldn't we be modelling the PMU then? > + =C2=A0 =C2=A0memory_region_init_ram(&s->bootreg_mem, NULL, "exynos4210.= bootreg", 0x4); > + =C2=A0 =C2=A0memory_region_add_subregion(system_mem, EXYNOS4210_SECOND_= CPU_BOOTREG, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&s->bootreg_mem); > + > +static int exynos4_board_smp_bootreg_addr[EXYNOS4_NUM_OF_BOARDS] =3D { > + =C2=A0 =C2=A0[EXYNOS4_BOARD_NURI] =C2=A0 =C2=A0 =3D EXYNOS4210_SECOND_C= PU_BOOTREG, > + =C2=A0 =C2=A0[EXYNOS4_BOARD_SMDKC210] =3D EXYNOS4210_SECOND_CPU_BOOTREG= , > +}; Is this actually likely to differ between boards, or is it really a propert= y of the SoC itself? See also note in other patch about reordering and merging this patch with an earlier one. -- PMM