From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmqic-0007dG-R0 for qemu-devel@nongnu.org; Mon, 16 Jan 2012 12:51:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rmqib-00066a-CR for qemu-devel@nongnu.org; Mon, 16 Jan 2012 12:51:42 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:51115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmqib-00066K-7n for qemu-devel@nongnu.org; Mon, 16 Jan 2012 12:51:41 -0500 Received: by qcsc2 with SMTP id c2so1779191qcs.4 for ; Mon, 16 Jan 2012 09:51:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1326674823-13069-5-git-send-email-afaerber@suse.de> References: <1326674823-13069-1-git-send-email-afaerber@suse.de> <1326674823-13069-5-git-send-email-afaerber@suse.de> Date: Mon, 16 Jan 2012 17:51:39 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno On 16 January 2012 00:46, Andreas F=C3=A4rber wrote: > normalizeFloat{32,64}Subnormal() expect the exponent as int16, not int. > This went unnoticed since int16 and uint16 were both typedef'ed to int. I think at the time I wrote that I was being slightly conservative because I didn't feel like confirming that we wouldn't overflow a 16 bit type. Anyway, I have tested this patch: * in combination with your others * with typedefs set up so all int16 &co are the minimum width they could be * with typedefs so int16 &co are all 64 bits wide and this all still gives the right results for ARM vfm, so Reviewed-by: Peter Maydell -- PMM