From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an5wN-0002bv-19 for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an5wG-0000Cn-Dr for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:57:18 -0400 Received: from mail-vk0-x22a.google.com ([2607:f8b0:400c:c05::22a]:36529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an5wG-0000Cb-9R for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:57:12 -0400 Received: by mail-vk0-x22a.google.com with SMTP id c4so57553220vkb.3 for ; Mon, 04 Apr 2016 07:57:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <57027DB9.8060806@redhat.com> References: <1459780549-12942-1-git-send-email-alex.bennee@linaro.org> <57027DB9.8060806@redhat.com> From: Peter Maydell Date: Mon, 4 Apr 2016 15:56:52 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Sean Bruno , =?UTF-8?B?QWxleCBCZW5uw6ll?= , QEMU Developers On 4 April 2016 at 15:44, Paolo Bonzini wrote: > On 04/04/2016 16:35, Alex Benn=C3=A9e wrote: >> Only the first patch has actually changed. Instead of moving the read >> inside the write seqlock it is now done using the seqlock_read_* >> primitives. >> >> Build tested on a FreeBSB/i386 VM with these applied: >> >> https://github.com/berrange/qemu/tree/freebsd-fixes >> >> There are still a ton of unrelated warnings being kicked out of the comp= iler >> though. On the VM "make check" fails at ... but as the build was >> broken beforehand I can't tell if this is a regression. It passes fine >> on my Linux box. >> >> Alex Benn=C3=A9e (2): >> cpus: don't use atomic_read for vm_clock_warp_start >> include/qemu/atomic: add compile time asserts >> >> cpus.c | 10 ++++++++- >> include/qemu/atomic.h | 58 ++++++++++++++++++++++++++++++--------------= ------- >> 2 files changed, 43 insertions(+), 25 deletions(-) >> > > Queued for 2.6, thanks. I will send a pull request later this week. It would be nice to fix this for rc1 (scheduled for tomorrow)... thanks -- PMM