From: Peter Maydell <peter.maydell@linaro.org>
To: John Snow <jsnow@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH 1/1] python/machine: Change default timeout to 30 seconds
Date: Sat, 25 Jul 2020 18:46:01 +0100 [thread overview]
Message-ID: <CAFEAcA8LWMp_GPaDCoMmASB+moH3wsxxR4=g27yVpOnmz3WoOA@mail.gmail.com> (raw)
In-Reply-To: <c3989867-effe-e763-dbc7-705d5f3827c9@redhat.com>
On Fri, 24 Jul 2020 at 17:31, John Snow <jsnow@redhat.com> wrote:
>
> On 7/20/20 4:20 PM, Eduardo Habkost wrote:
> > On Mon, Jul 20, 2020 at 12:02:52PM -0400, John Snow wrote:
> >> 3 seconds is too short for some tests running inside busy VMs. Build it out to
> >> a rather generous 30 seconds to find out conclusively if there are more severe
> >> problems in the merge/CI tests.
> >>
> >> Signed-off-by: John Snow <jsnow@redhat.com>
> >
> > It's weird how the hard shutdown method has a more graceful
> > timeout than graceful shutdown (60 seconds vs 3 seconds).
> >
> > I would make both have the same timeout, but it's better to try
> > this only after 5.1.0.
> >
> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> >
> >
>
> Peter, do you want to take this directly to see if it starts to fix the
> merge tests for you?
Applied to master, thanks. We'll see how it goes...
-- PMM
prev parent reply other threads:[~2020-07-25 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:02 [PATCH 0/1] python/machine: Change default timeout to 30 seconds John Snow
2020-07-20 16:02 ` [PATCH 1/1] " John Snow
2020-07-20 20:01 ` Eduardo Habkost
2020-07-20 20:06 ` John Snow
2020-07-20 20:20 ` Eduardo Habkost
2020-07-24 16:31 ` John Snow
2020-07-25 17:46 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8LWMp_GPaDCoMmASB+moH3wsxxR4=g27yVpOnmz3WoOA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).